oc/*: gracefully fail when user group is not configured

[stevekuznetsov]

All commands using the userv1 clients should be wrapped now.

$ for file in $( git grep -l 'clientset/versioned/typed/user/v1' | grep -v vendor ); do if ! grep -q 'CheckOAuthDisabledErr' $file; then echo $file; fi; done
pkg/cli/admin/groups/sync/interfaces.go    # just interfaces, no impl
pkg/cli/admin/prune/auth/group_test.go     # test
pkg/cli/admin/prune/auth/user.go           # helper func, caller handles it
pkg/cli/admin/prune/auth/user_test.go      # test
pkg/helpers/describe/describer.go          # TODO: need to figure this out
pkg/helpers/groupsync/grouplister.go       # helper func, caller handles it
pkg/helpers/groupsync/grouplister_test.go  # test
pkg/helpers/groupsync/grouppruner.go       # helper func, caller handles it
pkg/helpers/groupsync/grouppruner_test.go  # test
pkg/helpers/groupsync/groupsyncer.go       # helper func, caller handles it
pkg/helpers/groupsync/groupsyncer_test.go  # test
pkg/helpers/project/whoami.go              # helper func, caller handles it

Follow-ups:

• determine how to handle the describer functions
• also handle the oauth group

[ardaguclu]

nit: should be in oc/pkg group with the end of imports

[stevekuznetsov]

Do you have an import formatter enabled on the repo? I think you (and anyone making PRs) would appreciate your preferences being automated so these kinds of comments don't need to happen. OpenShift has an import formatter that I've seen other repos use.

[stevekuznetsov]

https://github.com/openshift-eng/openshift-goimports

[ardaguclu]

no need to add this check in here because we will support both cases(catch notfound error internally and use different endpoint)

[ardaguclu]

whoami should work with external OIDC

[stevekuznetsov]

For now, let's have it fail gracefully - when we're ready to have it work both ways, we can remove this.

[ardaguclu]

Thanks @stevekuznetsov

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ardaguclu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@stevekuznetsov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.