New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: Simplified kubectl component version check #1662
NO-JIRA: Simplified kubectl component version check #1662
Conversation
@ardaguclu: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold |
For more justification: #1661 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ardaguclu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold cancel |
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-cli-container-v4.16.0-202401241315.p0.g36702f9.assembly.stream for distgit openshift-enterprise-cli. |
With this PR #1656, we relaxed the kubectl component version
check by only allowing kubectl version in cli and cli-artifacts images and kubectl version between
other images. However, as seen in this revert #1660, there are other oc commands
having this strict component version check which caused failures in HCP.
This PR adopts simpler approach for kubectl specific component version checking. It simply
populates all the kubectl versions in a set and if the length is greater than 2(actual kubectl version 1.29.0 and the current ones 1.28.2) which means that this is indeed kubectl version mismatch.