Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-30212: oc adm catalog mirror: use ToSlash and FromSlash to unify the path separators #1680

Conversation

ingvagabund
Copy link
Member

Image label (operators.operatorframework.io.index.configs.v1), mappings and other code parts uses Unix path separators (/). github.com/docker/docker/pkg/archive implementation produces windows path separators when running on Windows platform. ToSlash and FromSlash allows to treat all path seperators as Unix path seperators.

@openshift-ci-robot
Copy link

@ingvagabund: Jira Issue OCPBUGS-28864 is in a security level that is not in the allowed security levels for this repo.
Allowed security levels for this repo are:

  • Red Hat Employee
  • default

In response to this:

Image label (operators.operatorframework.io.index.configs.v1), mappings and other code parts uses Unix path separators (/). github.com/docker/docker/pkg/archive implementation produces windows path separators when running on Windows platform. ToSlash and FromSlash allows to treat all path seperators as Unix path seperators.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2024
@ingvagabund
Copy link
Member Author

/retest-required

@ingvagabund ingvagabund force-pushed the oc-adm-catalog-mirror-windows-path-separator branch from 492fbf3 to 2046ed1 Compare February 12, 2024 10:27
@ingvagabund ingvagabund changed the title wip: OCPBUGS-28864: oc adm catalog mirror: use ToSlash and FromSlash to unify the path separators OCPBUGS-28864: oc adm catalog mirror: use ToSlash and FromSlash to unify the path separators Feb 21, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 21, 2024
@ingvagabund
Copy link
Member Author

/hold
For pre-merge testing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2024
@ardaguclu
Copy link
Member

/lgtm
Is the security failure temporary;
/test security

@ardaguclu
Copy link
Member

metal also may rely on this functionality and I think, we need to have it green;
/test e2e-metal-ipi-ovn-ipv6

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2024
Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024
@ingvagabund
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2024
@ingvagabund ingvagabund changed the title OCPBUGS-28864: oc adm catalog mirror: use ToSlash and FromSlash to unify the path separators OCPBUGS-30212: oc adm catalog mirror: use ToSlash and FromSlash to unify the path separators Mar 4, 2024
@ingvagabund
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

@ingvagabund: An error was encountered querying GitHub for users with public email (yinzhou@redhat.com) for bug OCPBUGS-30212 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: connect: connection refused

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

Image label (operators.operatorframework.io.index.configs.v1), mappings and other code parts uses Unix path separators (/). github.com/docker/docker/pkg/archive implementation produces windows path separators when running on Windows platform. ToSlash and FromSlash allows to treat all path seperators as Unix path seperators.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@ingvagabund: An error was encountered querying GitHub for users with public email (yinzhou@redhat.com) for bug OCPBUGS-30212 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: connect: connection refused

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ingvagabund
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 4, 2024
@openshift-ci-robot
Copy link

@ingvagabund: This pull request references Jira Issue OCPBUGS-30212, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from zhouying7780 March 4, 2024 18:23
@ingvagabund
Copy link
Member Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@ingvagabund: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund
Copy link
Member Author

/cherry-pick release-4.14

@openshift-cherrypick-robot

@ingvagabund: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-cherrypick-robot

@ingvagabund: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund
Copy link
Member Author

/cherry-pick release-4.13

@ingvagabund
Copy link
Member Author

/cherry-pick release-4.12

@openshift-cherrypick-robot

@ingvagabund: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ingvagabund: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 91ba77a and 2 for PR HEAD 66284bc in total

@ingvagabund
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 92ede80 and 1 for PR HEAD 66284bc in total

Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@ingvagabund: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1c257b8 into openshift:master Mar 6, 2024
13 checks passed
@openshift-ci-robot
Copy link

@ingvagabund: Jira Issue OCPBUGS-30212: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30212 has been moved to the MODIFIED state.

In response to this:

Image label (operators.operatorframework.io.index.configs.v1), mappings and other code parts uses Unix path separators (/). github.com/docker/docker/pkg/archive implementation produces windows path separators when running on Windows platform. ToSlash and FromSlash allows to treat all path seperators as Unix path seperators.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@ingvagabund: new pull request created: #1698

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ingvagabund: new pull request created: #1699

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ingvagabund: new pull request created: #1700

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ingvagabund: new pull request created: #1701

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-cli-container-v4.16.0-202403060709.p0.g1c257b8.assembly.stream.el8 for distgit openshift-enterprise-cli.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-03-06-174829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants