Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRT-1503: Tools image no longer has python;adding #1682

Merged
merged 1 commit into from Feb 12, 2024
Merged

TRT-1503: Tools image no longer has python;adding #1682

merged 1 commit into from Feb 12, 2024

Conversation

jcpowermac
Copy link
Contributor

Something has recently changed with the parent images of the tools image where it no longer has python causing CI failures. Adding python3 to the tools image.

@jcpowermac
Copy link
Contributor Author

https://prow.ci.openshift.org/?type=periodic&job=*nightly*4.16*&cluster=vsphere02

# jcallen @ fedora in ~ [8:17:06] 
$ podman run -it registry.ci.openshift.org/ocp/4.16-art-latest-2024-02-12-052140:tools /bin/bash
[root@12ea73916ef1 /]# whereis python
python: /usr/lib/python3.6 /usr/lib64/python3.6 /usr/include/python3.6m /usr/share/man/man1/python.1.gz
[root@12ea73916ef1 /]# which python
/usr/bin/which: no python in (/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin)

@jcpowermac jcpowermac changed the title Tools image no longer has python;adding TRT-1503 - Tools image no longer has python;adding Feb 12, 2024
@jcpowermac
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@jcpowermac: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac jcpowermac changed the title TRT-1503 - Tools image no longer has python;adding TRT-1503: Tools image no longer has python;adding Feb 12, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 12, 2024 •
edited by openshift-ci bot

@jcpowermac: This pull request references TRT-1503 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Something has recently changed with the parent images of the tools image where it no longer has python causing CI failures. Adding python3 to the tools image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac
Copy link
Contributor Author

/assign ardaguclu

@soltysh
Copy link
Member

soltysh commented Feb 12, 2024

/assign @soltysh

ardaguclu
ardaguclu reviewed Feb 12, 2024
View reviewed changes
images/tools/Dockerfile
@@ -36,6 +36,7 @@ RUN INSTALL_PKGS="\
xfsprogs \
fio \
stress-ng \
python36 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why strictly python 3.6?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was the package available when I tested it locally. I am not partial to a specific minor of 3.x if you have another suggestion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first version of this PR was python3, I am wondering is there any reason to use python36. If not, I'd prefer to move forward with python3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, updated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcpowermac you are right. python3 gaves an error package python3 is not installed with an exit code 1. We have to use python36

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the reason why I set it to python36

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_oc/1682/pull-ci-openshift-oc-master-images/1757077012503072768#1:build-log.txt%3A982

@jcpowermac jcpowermac force-pushed the add-python-tools branch 3 times, most recently from 1cda4c8 to 227e8d9 Compare February 12, 2024 16:39
@ardaguclu
Copy link
Member

Thanks
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 12, 2024
soltysh
soltysh requested changes Feb 12, 2024
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
python39.x86_64 : Version 3.9 of the Python interpreter
seems to be the latest available Red Hat Enterprise Linux release 8.6 (Ootpa)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2024
@jcpowermac
Copy link
Contributor Author

/hold python39.x86_64 : Version 3.9 of the Python interpreter seems to be the latest available Red Hat Enterprise Linux release 8.6 (Ootpa)

Switched to 39, let's see if it works.

@soltysh
Copy link
Member

soltysh commented Feb 12, 2024

Also, I just did:

$ oc adm release info --image-for tools registry.ci.openshift.org/ocp/release:4.16.0-0.ci-2024-02-12-052859
registry.ci.openshift.org/ocp/4.16-2024-02-12-052859@sha256:d2dc7f2c6aede00120acc5fa437bd0648b1986764a1d38b5ec8d44334053e675
$ podman run -it --rm --entrypoint /bin/bash registry.ci.openshift.org/ocp/4.16-2024-02-12-052859@sha256:d2dc7f2c6aede00120acc5fa437bd0648b1986764a1d38b5ec8d44334053e675
...
[root@b7a8dc58573a /]# which python
/usr/bin/python
[root@b7a8dc58573a /]# python
Python 3.6.8 (default, Jan 11 2024, 14:44:18) 
[GCC 8.5.0 20210514 (Red Hat 8.5.0-10)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>>

so it looks like the tools image already has the necessary python, so I'm confused now.

@ardaguclu
Copy link
Member

Hmmm, I check the one referenced above that does not have python registry.ci.openshift.org/ocp/4.16-art-latest-2024-02-12-052140:tools. It seems that registry.ci.openshift.org/ocp/release:4.16.0-0.ci-2024-02-12-052859 has it.

@jcpowermac
Copy link
Contributor Author

Also, I just did:

$ oc adm release info --image-for tools registry.ci.openshift.org/ocp/release:4.16.0-0.ci-2024-02-12-052859
registry.ci.openshift.org/ocp/4.16-2024-02-12-052859@sha256:d2dc7f2c6aede00120acc5fa437bd0648b1986764a1d38b5ec8d44334053e675
$ podman run -it --rm --entrypoint /bin/bash registry.ci.openshift.org/ocp/4.16-2024-02-12-052859@sha256:d2dc7f2c6aede00120acc5fa437bd0648b1986764a1d38b5ec8d44334053e675
...
[root@b7a8dc58573a /]# which python
/usr/bin/python
[root@b7a8dc58573a /]# python
Python 3.6.8 (default, Jan 11 2024, 14:44:18) 
[GCC 8.5.0 20210514 (Red Hat 8.5.0-10)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>>

so it looks like the tools image already has the necessary python, so I'm confused now.

Likewise, only periodics are failing with missing python in the vsphere dns step.

I narrowed it down to:

has python - registry.ci.openshift.org/ocp/4.16-art-latest-2024-02-08-073857:tools
does not have python - registry.ci.openshift.org/ocp/4.16-art-latest-2024-02-09-194858:tools

@soltysh
Copy link
Member

soltysh commented Feb 12, 2024

has python - registry.ci.openshift.org/ocp/4.16-art-latest-2024-02-08-073857:tools does not have python - registry.ci.openshift.org/ocp/4.16-art-latest-2024-02-09-194858:tools

Yeah, I just checked the nightlies (registry.ci.openshift.org/ocp/release:4.16.0-0.nightly-2024-02-11-143825) those indeed are missing the python. But to keep it consistent, let's use the one that's already included in the ci builds, in that case. That was 3.6.8, so can you revert to that? Sorry for the back and forth 😅

@jcpowermac
Copy link
Contributor Author

But to keep it consistent, let's use the one that's already included in the ci builds, in that case. That was 3.6.8, so can you revert to that? Sorry for the back and forth 😅

np! moved back

soltysh
soltysh approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, jcpowermac, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit cf7b09c into openshift:master Feb 12, 2024
12 of 13 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-cli-container-v4.16.0-202402130109.p0.gcf7b09c.assembly.stream.el8 for distgit openshift-enterprise-cli.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardaguclu ardaguclu ardaguclu left review comments

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@soltysh soltysh

@ardaguclu ardaguclu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jcpowermac @openshift-ci-robot @soltysh @ardaguclu @openshift-bot