Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Bump k8s dependencies to 1.29.1 #1684

Conversation

ardaguclu
Copy link
Member

This PR bumps k8s dependencies from 1.29.0 to 1.29.1 to get important kubectl patches (kubernetes/kubectl@6b2d872, kubernetes/kubectl@778ed2b).

This original PR #1681 was reverted in #1683
because some images bases on cli image still use 1.28.2 kubectl version which is not correct.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 13, 2024
@openshift-ci-robot
Copy link

@ardaguclu: This pull request explicitly references no jira issue.

In response to this:

This PR bumps k8s dependencies from 1.29.0 to 1.29.1 to get important kubectl patches (kubernetes/kubectl@6b2d872, kubernetes/kubectl@778ed2b).

This original PR #1681 was reverted in #1683
because some images bases on cli image still use 1.28.2 kubectl version which is not correct.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ardaguclu
Copy link
Member Author

ardaguclu commented Feb 13, 2024

/hold
until test case is added into origin and new test passes in here
Possible test case would take ~30 minutes which is not feasible. In any case, we should hold this PR until a permanent fix for the problem.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 13, 2024
@ardaguclu
Copy link
Member Author

ardaguclu commented Feb 14, 2024

required fix for oc #1685 , for hypershift openshift/hypershift#3575

@ardaguclu
Copy link
Member Author

/retest

1 similar comment
@ardaguclu
Copy link
Member Author

/retest

@ardaguclu
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2024
@ingvagabund
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ardaguclu
Copy link
Member Author

/hold
to merge this in next week

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2024
@ardaguclu
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f82c7db and 2 for PR HEAD 6e76658 in total

@ardaguclu
Copy link
Member Author

/retest

1 similar comment
@ardaguclu
Copy link
Member Author

/retest

Copy link
Contributor

openshift-ci bot commented Feb 27, 2024

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 91ba77a into openshift:master Feb 27, 2024
13 checks passed
@ardaguclu ardaguclu deleted the revert-1683-revert-1681-bump-1.29.1 branch February 27, 2024 17:15
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-cli-container-v4.16.0-202402272209.p0.g91ba77a.assembly.stream.el8 for distgit openshift-enterprise-cli.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants