Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: update featuregate diff for clusterprofiles #1714

Merged
merged 2 commits into from Mar 28, 2024
Merged

NO-JIRA: update featuregate diff for clusterprofiles #1714

merged 2 commits into from Mar 28, 2024

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Mar 22, 2024 •
edited

FeatureGates can vary by clusterprofile, this adds handling for both new and old style and updates the format to be table.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Mar 27, 2024

/hold cancel

includes revert of #1708 so we can use the newly built version while the image bits are worked out.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Mar 27, 2024

/retest

@ardaguclu ardaguclu mentioned this pull request Mar 28, 2024
Closed
@deads2k deads2k changed the title update featuregate diff for clusterprofiles NO-JIRA: update featuregate diff for clusterprofiles Mar 28, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 28, 2024
@openshift-ci-robot
Copy link

@deads2k: This pull request explicitly references no jira issue.

In response to this:

FeatureGates can vary by clusterprofile, this adds handling for both new and old style and updates the format to be table.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@deads2k deads2k added lgtm Indicates that a PR is ready to be merged. and removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Mar 28, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Mar 28, 2024

manually tested by Brad.

@deads2k deads2k added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 28, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

@deads2k: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 d17afd1 link false /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 52eca22 into openshift:master Mar 28, 2024
12 of 13 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-cli-container-v4.16.0-202403290310.p0.g52eca22.assembly.stream.el8 for distgit openshift-enterprise-cli.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deads2k @openshift-ci-robot @openshift-bot