-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTA-1154: pkg/cli/admin/upgrade/status: Drop free-form Progressing output line #1753
OTA-1154: pkg/cli/admin/upgrade/status: Drop free-form Progressing output line #1753
Conversation
Following up on 7977ec9 (pkg/cli/admin/upgrade/status: Move Failing from free-form to updateInsight, 2024-04-24, openshift#1744), drop the remaining free-form output. With this change, all happy-case stdout output should be via structured updateInsight. The 'Update Health' section at the end of the output is now the only cluster-scoped summary of overall update progress. Updated fixtures generated with: $ export OC_ENABLE_CMD_UPGRADE_STATUS=true $ for X in pkg/cli/admin/upgrade/status/examples/*-cv.yaml; do ./oc adm upgrade status --mock-clusterversion "${X}" > "${X/-cv.yaml/.output}"; ./oc adm upgrade status --details=all --mock-clusterversion "${X}" > "${X/-cv.yaml/.detailed-output}"; done
@wking: This pull request references OTA-1154 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retest-required
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@wking: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
51e5705
into
openshift:master
[ART PR BUILD NOTIFIER] This PR has been included in build ose-tools-container-v4.17.0-202404302014.p0.g51e5705.assembly.stream.el9 for distgit ose-tools. |
Following up on 7977ec9 (#1744), drop the remaining free-form output. With this change, all happy-case stdout output should be via structured
updateInsight
. TheUpdate Health
section at the end of the output is now the only cluster-scoped summary of overall update progress. Generated the updated fixtures with: