Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTH-482: set required-scc annotation to privileged for node debug pods #1763

Merged
merged 1 commit into from
May 21, 2024

Conversation

liouk
Copy link
Member

@liouk liouk commented May 13, 2024

No description provided.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2024

@liouk: This pull request references AUTH-482 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 13, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2024
@openshift-ci openshift-ci bot requested review from ardaguclu and soltysh May 13, 2024 12:26
@liouk
Copy link
Member Author

liouk commented May 15, 2024

/retest

@liouk liouk changed the title WIP: AUTH-482: set required-scc annotation to privileged for node debug pods AUTH-482: set required-scc annotation to privileged for node debug pods May 15, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2024
@ardaguclu
Copy link
Member

/lgtm
/hold
@liouk in case you think pre-merge tests requiring for this change. Otherwise, feel free to cancel hold.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
Copy link
Contributor

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, liouk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2024
@liouk
Copy link
Member Author

liouk commented May 15, 2024

@ardaguclu in non-runlevel namespaces, where SCC admission is enabled, node debug pods are getting anyway admitted with the privileged SCC; in runlevel namespaces, admission is disabled so this change isn't effective.

This means that overall we're not changing any behavior here, just making the required SCC explicit. Therefore I don't think pre-merge tests are required for this.

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2024
@liouk
Copy link
Member Author

liouk commented May 16, 2024

/retest

@liouk
Copy link
Member Author

liouk commented May 21, 2024

/retest-required

Copy link
Contributor

openshift-ci bot commented May 21, 2024

@liouk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6e6bf1d into openshift:master May 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants