OCPBUGS-32682: Fix the retrieval of API objects with an empty name #1765
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@Davoska: This pull request references Jira Issue OCPBUGS-32682, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
approved
|
/test |
|
/test all |
|
@petr-muller: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@petr-muller: This pull request references Jira Issue OCPBUGS-32682, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label tide/merge-method-squash |
This commit will fix an occuring error that resulted in the error message: `error: resource name may not be empty` This was caused by not checking the value of the machineconfiguration.openshift.io/currentConfig and machineconfiguration.openshift.io/desiredConfig annotations of nodes. In the event, the annotation was not set or was empty, the command would try to get a MachineConfig with an empty name from the API server. The commit also adds additional functionalities and testing for cases when different MCD annotations are missing. The general strategy is to declare the states of nodes only when they are provably in the specific states.
openshift-ci
bot
added
the
tide/merge-method-squash
Davoska
force-pushed
the
OCPBUGS-32682-status-fails-with-error
branch
from
6926a96
to
5bc86a6
Compare
|
@Davoska: This pull request references Jira Issue OCPBUGS-32682, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/lgtm I always forget 😓 |
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Davoska, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Davoska: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@Davoska: Jira Issue OCPBUGS-32682: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-32682 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-tools-container-v4.17.0-202405151441.p0.g1073b29.assembly.stream.el9 for distgit ose-tools. |
The main goal of this pull request is to fix an occurring error that resulted in the error
message:
error: resource name may not be emptyThis was caused by not checking the value of the
machineconfiguration.openshift.io/currentConfig and
machineconfiguration.openshift.io/desiredConfig annotations of nodes.
In the event, the annotation was not set or was empty, the command would
try to get a MachineConfig with an empty name from the API server.
The commit also adds additional functionalities and testing for cases
when different MCD annotations are missing.
The general strategy is to declare the states of nodes only when they
are provably in the specific states.
This pull request references https://issues.redhat.com//browse/OCPBUGS-32682