OCPBUGS-33762: Hardcode resource groups/kinds for now

[petr-muller]

Previous code used GroupVersionKind method on actual resources to determine group/kind strings for them, but client-go unfortunately drops TypeMeta on resources processed by typed client (kubernetes/client-go#1328, kubernetes/client-go#541). Fortunately we know what types we build insights for, so we can use appropriate strings from client code for groups and hardcode kinds ourselves.

[openshift-ci-robot]

@petr-muller: This pull request references Jira Issue OCPBUGS-33762, which is invalid:

• expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Previous code used GroupVersionKind method on actual resources to determine group/kind strings for them, but client-go unfortunately drops TypeMeta on resources processed by typed client (kubernetes/client-go#1328, kubernetes/client-go#541). Fortunately we know what types we build insights for, so we can use appropriate strings from client code for groups and hardcode kinds ourselves.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[petr-muller]

/jira refresh

[openshift-ci-robot]

@petr-muller: This pull request references Jira Issue OCPBUGS-33762, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @evakhoni

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[petr-muller]

/test e2e-aws-ovn-upgrade

[wking]

/lgtm

[Davoska]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Davoska, petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/cli/admin/upgrade/OWNERS [Davoska,petr-muller,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 6e6bf1d and 2 for PR HEAD fad39d2 in total

[openshift-ci]

@petr-muller: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@petr-muller: Jira Issue OCPBUGS-33762: All pull requests linked via external trackers have merged:

• openshift/oc#1773

Jira Issue OCPBUGS-33762 has been moved to the MODIFIED state.

In response to this:

Previous code used GroupVersionKind method on actual resources to determine group/kind strings for them, but client-go unfortunately drops TypeMeta on resources processed by typed client (kubernetes/client-go#1328, kubernetes/client-go#541). Fortunately we know what types we build insights for, so we can use appropriate strings from client code for groups and hardcode kinds ourselves.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-tools-container-v4.17.0-202405212243.p0.g44e3cd9.assembly.stream.el9 for distgit ose-tools.
All builds following this will include this PR.

[petr-muller]

/cherry-pick release-4.16

[openshift-cherrypick-robot]

@petr-muller: #1773 failed to apply on top of branch "release-4.16":

Applying: update status: minor code cleanups
Using index info to reconstruct a base tree...
A	pkg/cli/admin/upgrade/status/alerts.go
A	pkg/cli/admin/upgrade/status/alerts_test.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pkg/cli/admin/upgrade/status/alerts_test.go deleted in HEAD and modified in update status: minor code cleanups. Version update status: minor code cleanups of pkg/cli/admin/upgrade/status/alerts_test.go left in tree.
CONFLICT (modify/delete): pkg/cli/admin/upgrade/status/alerts.go deleted in HEAD and modified in update status: minor code cleanups. Version update status: minor code cleanups of pkg/cli/admin/upgrade/status/alerts.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 update status: minor code cleanups
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[petr-muller]

Hm, will needs alerts to land first :/

[petr-muller]

/cherry-pick release-4.16

[openshift-cherrypick-robot]

@petr-muller: new pull request created: #1796

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.