Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1778019: If required flag is not passed, don't print usage menu, only print error #234

Merged
merged 2 commits into from Jan 8, 2020

Conversation

sallyom
Copy link
Contributor

@sallyom sallyom commented Dec 28, 2019

Don't print usage menu upon error, only print error message.

/cc @soltysh

@openshift-ci-robot
Copy link

@sallyom: This pull request references Bugzilla bug 1778019, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1778019: If required flag is not passed, don't print usage menu, only print error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 28, 2019
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need the upstream commit from upstream 86693 b/c when we replace the name and act as kubectl you want the problem fixed there too.

@sallyom
Copy link
Contributor Author

sallyom commented Jan 6, 2020

You also need the upstream commit from upstream 86693 b/c when we replace the name and act as kubectl you want the problem fixed there too.

opened openshift/kubernetes-kubectl#9 will pull it in when it merges

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 7, 2020
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sallyom, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2020
@openshift-merge-robot openshift-merge-robot merged commit 2f3a161 into openshift:master Jan 8, 2020
@openshift-ci-robot
Copy link

@sallyom: All pull requests linked via external trackers have merged. Bugzilla bug 1778019 has been moved to the MODIFIED state.

In response to this:

Bug 1778019: If required flag is not passed, don't print usage menu, only print error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants