Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1788088: When "oc status" run, "panic: runtime error: invalid memory address or nil pointer dereference" is shown #241

Merged
merged 1 commit into from Jan 6, 2020
Merged

Bug 1788088: When "oc status" run, "panic: runtime error: invalid memory address or nil pointer dereference" is shown #241

merged 1 commit into from Jan 6, 2020

Conversation

bysnupy
Copy link
Member

@bysnupy bysnupy commented Jan 6, 2020 •
edited

e.g.>

// There is a result without no problem as follows.
$ oc status
In project test on server https://api.ocp4.example.com:6443

job/pi manages perl
  created 25 minutes ago 1/1 completed 0 running

// If job spec pointer is nil, the result is empty string instead of runtime error.
$ oc status
In project test on server https://api.ocp4.example.com:6443

job/pi manages perl

@bysnupy
Suppress nil pointer dereference for job spec
48c80f9 
If job spec pointer dereference is nil, the result will be empty string instead of showing wrong result or runtime error.

Reference: https://bugzilla.redhat.com/show_bug.cgi?id=1788016
@openshift-ci-robot
Copy link

@bysnupy: This pull request references Bugzilla bug 1788016, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1788016: When "oc status" run, "panic: runtime error: invalid memory address or nil pointer dereference" is shown

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 6, 2020
@openshift-ci-robot
Copy link

Hi @bysnupy. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 6, 2020
@mfojtik
Copy link
Member

mfojtik commented Jan 6, 2020

/retitle Bug 1788088: When "oc status" run, "panic: runtime error: invalid memory address or nil pointer dereference" is shown

@openshift-ci-robot openshift-ci-robot changed the title Bug 1788016: When "oc status" run, "panic: runtime error: invalid memory address or nil pointer dereference" is shown Bug 1788088: When "oc status" run, "panic: runtime error: invalid memory address or nil pointer dereference" is shown Jan 6, 2020
@openshift-ci-robot
Copy link

@bysnupy: This pull request references Bugzilla bug 1788088, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1788088: When "oc status" run, "panic: runtime error: invalid memory address or nil pointer dereference" is shown

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Member

mfojtik commented Jan 6, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 6, 2020
@openshift-ci-robot
Copy link

@mfojtik: This pull request references Bugzilla bug 1788088, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Member

mfojtik commented Jan 6, 2020

/ok-to-test
/lgtm

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bysnupy, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2020
@mfojtik
Copy link
Member

mfojtik commented Jan 6, 2020

@bysnupy i cloned the BZ as you fixing this bug in 4.4.0 release but the original BZ you linked is for 4.2.

I would leave it up to @soltysh to decide whether he want to backport this down to 4.2 (it will require backporting and verifying in 4.3 as well)

@openshift-ci-robot
Copy link

@bysnupy: This pull request references Bugzilla bug 1788088, which is valid.

In response to this:

Bug 1788088: When "oc status" run, "panic: runtime error: invalid memory address or nil pointer dereference" is shown

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2619bdb into openshift:master Jan 6, 2020
@openshift-ci-robot
Copy link

@bysnupy: All pull requests linked via external trackers have merged. Bugzilla bug 1788088 has been moved to the MODIFIED state.

In response to this:

Bug 1788088: When "oc status" run, "panic: runtime error: invalid memory address or nil pointer dereference" is shown

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Member

soltysh commented Jan 7, 2020

/cherry-pick release-4.3

@openshift-cherrypick-robot
Copy link

@soltysh: #241 failed to apply on top of branch "release-4.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	pkg/helpers/describe/projectstatus.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/helpers/describe/projectstatus.go
CONFLICT (content): Merge conflict in pkg/helpers/describe/projectstatus.go
Patch failed at 0001 Suppress nil pointer dereference for job spec

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Member

soltysh commented Jan 7, 2020

Manual backport in #243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@mfojtik mfojtik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bysnupy @openshift-ci-robot @mfojtik @openshift-bot @soltysh @openshift-cherrypick-robot @openshift-merge-robot