Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout option for must-gather as a optional parameter #258

Merged
merged 1 commit into from Feb 19, 2020
Merged

Add timeout option for must-gather as a optional parameter #258

merged 1 commit into from Feb 19, 2020

Conversation

crombus
Copy link
Contributor

@crombus crombus commented Jan 16, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 16, 2020
@crombus
Copy link
Contributor Author

crombus commented Jan 16, 2020

it resolves this issue #203

@crombus
Copy link
Contributor Author

crombus commented Jan 16, 2020

/assign @soltysh

soltysh
soltysh requested changes Jan 16, 2020
View reviewed changes
pkg/cli/admin/mustgather/mustgather.go Outdated Show resolved Hide resolved
@crombus crombus requested a review from soltysh January 17, 2020 05:54
@crombus crombus force-pushed the master branch 2 times, most recently from e362f8d to 32779b4 Compare January 21, 2020 10:53
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2020
soltysh
soltysh requested changes Jan 21, 2020
View reviewed changes
pkg/cli/admin/mustgather/mustgather.go Outdated Show resolved Hide resolved
@crombus
Copy link
Contributor Author

crombus commented Jan 28, 2020

@soltysh can be little more specific what are you asking. I am sorry I could not understand the request you made.

soltysh
soltysh approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crombus, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@crombus
Copy link
Contributor Author

crombus commented Feb 19, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c22b888 into openshift:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@crombus @openshift-ci-robot @openshift-bot @soltysh @openshift-merge-robot