Bug 1801064: Deprecate Pipelines in new-app/build #291
Conversation
|
@adambkaplan: This pull request references Bugzilla bug 1801064, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/invalid-bug
|
/bugzilla refresh |
|
@adambkaplan: This pull request references Bugzilla bug 1801064, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
/assign @soltysh |
openshift-ci-robot
added
the
approved
pkg/cli/newapp/newapp.go
Outdated
| @@ -457,6 +457,9 @@ func (o *AppOptions) RunNewApp() error { | |||
| installing = append(installing, t) | |||
| } | |||
| case *buildv1.BuildConfig: | |||
| if t.Spec.Strategy.Type == buildv1.JenkinsPipelineBuildStrategyType { | |||
| fmt.Fprintf(out, "%sNOTICE: the JenkinsPipeline strategy is deprecated; consider using Jenkinsfiles directly on Jenkins or OpenShift Pipelines.\n", indent) | |||
There was a problem hiding this comment.
Log to o.Action.ErrOut and make the message similar to https://github.com/openshift/oc/blob/master/pkg/cli/rollout/latest.go#L114
There was a problem hiding this comment.
@soltysh done in latest push.
pkg/cli/newbuild/newbuild.go
Outdated
| @@ -228,6 +228,9 @@ func (o *BuildOptions) RunNewBuild() error { | |||
| for _, item := range result.List.Items { | |||
| switch t := item.(type) { | |||
| case *buildv1.BuildConfig: | |||
| if t.Spec.Strategy.Type == buildv1.JenkinsPipelineBuildStrategyType { | |||
| fmt.Fprintf(out, "%sNOTICE: the JenkinsPipeline strategy is deprecated; consider using Jenkinsfiles directly on Jenkins or OpenShift Pipelines.\n", indent) | |||
Add a warning to `oc new-app` and `oc new-build` if a Jenkins pipeline strategy build was created.
adambkaplan
force-pushed
the
new-build-pipeline-depr
branch
from
bfe27ca
to
ea0a4a2
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@adambkaplan: All pull requests linked via external trackers have merged. Bugzilla bug 1801064 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add a warning to
oc new-appandoc new-buildif a Jenkins pipeline strategy build was created.