Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add since-second and since-time feature so that pod #322

Merged
merged 1 commit into from Jun 3, 2020
Merged

Add since-second and since-time feature so that pod #322

merged 1 commit into from Jun 3, 2020

Conversation

crombus
Copy link
Contributor

@crombus crombus commented Feb 27, 2020

logs can be gathered at a particular time.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 27, 2020
@crombus crombus force-pushed the time_option branch 2 times, most recently from 2e5d6a9 to 9e48b5c Compare March 3, 2020 06:47
@crombus
Copy link
Contributor Author

crombus commented Mar 3, 2020

/assign @soltysh

@crombus
Copy link
Contributor Author

crombus commented Mar 3, 2020

/assign @deads2k

soltysh
soltysh requested changes Mar 4, 2020
View reviewed changes
go.sum Outdated Show resolved Hide resolved
pkg/cli/admin/inspect/inspect.go Outdated Show resolved Hide resolved
@crombus crombus requested a review from soltysh March 9, 2020 13:46
@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2020
soltysh
soltysh requested changes Mar 27, 2020
View reviewed changes
pkg/cli/admin/inspect/inspect.go Outdated Show resolved Hide resolved
@crombus crombus requested a review from soltysh April 7, 2020 05:33
soltysh
soltysh requested changes Apr 14, 2020
View reviewed changes
pkg/cli/admin/inspect/inspect.go Outdated Show resolved Hide resolved
@crombus crombus force-pushed the time_option branch 2 times, most recently from 74e958c to c7f9dd1 Compare April 20, 2020 07:00
@crombus crombus requested a review from soltysh April 20, 2020 07:01
soltysh
soltysh requested changes Apr 20, 2020
View reviewed changes
pkg/cli/admin/inspect/inspect.go Outdated Show resolved Hide resolved
pkg/cli/admin/inspect/inspect.go Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2020
@crombus crombus requested a review from soltysh April 21, 2020 12:53
soltysh
soltysh requested changes Apr 22, 2020
View reviewed changes
pkg/cli/admin/inspect/inspect.go Outdated Show resolved Hide resolved
soltysh
soltysh requested changes Apr 29, 2020
View reviewed changes
pkg/cli/admin/inspect/pod.go Outdated Show resolved Hide resolved
@crombus crombus requested a review from soltysh April 30, 2020 15:41
soltysh
soltysh requested changes May 4, 2020
View reviewed changes
pkg/cli/admin/inspect/inspect.go Outdated Show resolved Hide resolved
@crombus crombus requested a review from soltysh May 5, 2020 10:15
soltysh
soltysh requested changes May 7, 2020
View reviewed changes
pkg/cli/admin/inspect/pod.go Outdated Show resolved Hide resolved
pkg/cli/admin/inspect/inspect.go Show resolved Hide resolved
@crombus crombus requested a review from soltysh May 11, 2020 11:42
@crombus
Add since-second and since-time feature so that pod
d64d9a2 
logs can be gathered at a particular time.
soltysh
soltysh approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold cancel

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 12, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crombus, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2020
@soltysh
Copy link
Member

soltysh commented May 12, 2020

/retest

@crombus crombus requested a review from soltysh May 14, 2020 10:53
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@crombus
Copy link
Contributor Author

crombus commented Jun 3, 2020

/test e2e-aws

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7d56fd6 into openshift:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@soltysh soltysh

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@crombus @openshift-ci-robot @soltysh @openshift-bot @deads2k @openshift-merge-robot