Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oc rsh: properly shadow position of -- #375

Commits on Apr 6, 2020

  1. oc rsh: properly shadow position of --

    As of k8s 1.18, kubectl exec expects the command preceded by '--' as seen from the help:
    ```
    Usage:
      kubectl exec (POD | TYPE/NAME) [-c CONTAINER] [flags] -- COMMAND [args...] [options]
    ```
    
    If '--' is not present, kubectl exec prints the following informative message:
    ```
    kubectl exec [POD] [COMMAND] is DEPRECATED and will be removed in a future version. Use kubectl kubectl exec [POD] -- [COMMAND] instead.
    ```
    
    The message is still informative though given oc rsh does not require additional '--',
    it's confusing.
    ingvagabund committed Apr 6, 2020
    Copy the full SHA
    1e07b44 View commit details
    Browse the repository at this point in the history