oc adm catalog mirror updates: mac/windows, bundle image support, quay.io support #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecordell
force-pushed
the
oc-mirror-quay
branch
6 times, most recently
from
649a5d4
to
279ab12
Compare
|
/test unit |
ecordell
force-pushed
the
oc-mirror-quay
branch
2 times, most recently
from
c7feb1d
to
20196ac
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
soltysh
requested changes
Apr 11, 2020
There was a problem hiding this comment.
I'd expect the following set of commits in this PR:
UPSTREAM: <drop>: drop operator-registry patchdropping that carry patch- bump operator-registry
- move mirroring from operator-registry to oc <- will this get us closer to dropping the operator-registry dep?
- updates to mirroring
- bump to pick up sqlite dep
- generated changes
Yes it will - we're actually fine to remove |
ecordell
force-pushed
the
oc-mirror-quay
branch
from
20196ac
to
529a5db
Compare
|
@soltysh updated and matches your suggested commit splitting |
allow mapping into a single namespace this supports quay.io which doesn't allow nested paths for images and doesn't allow creating orgs via push make the number of path components configuration for catalog mirror defaults to 2, which is what quay.io requires
ecordell
force-pushed
the
oc-mirror-quay
branch
from
529a5db
to
fe48ca0
Compare
Yes - please. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/cherry-pick release-4.4 |
|
@ecordell: #384 failed to apply on top of branch "release-4.4": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies and improves the mirroring support in
oc adm catalog mirror.DESTas a quay.io org, and the image will be renamed for quay (1 path component for org, the rest converted to a repo name).Example:
will generate mappings like
quay.io/coreos/prometheus-operator@sha256:3daa69a8c6c2f1d35dcf1fe48a7cd8b230e55f5229a1ded438f687debade5bcf->quay.io/my-org/coreos-prometheus-operator:1ebe036a