New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oc adm catalog mirror updates: mac/windows, bundle image support, quay.io support #384
oc adm catalog mirror updates: mac/windows, bundle image support, quay.io support #384
Conversation
649a5d4
to
279ab12
Compare
/test unit |
c7feb1d
to
20196ac
Compare
/retest |
2 similar comments
/retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expect the following set of commits in this PR:
UPSTREAM: <drop>: drop operator-registry patch
dropping that carry patch- bump operator-registry
- move mirroring from operator-registry to oc <- will this get us closer to dropping the operator-registry dep?
- updates to mirroring
- bump to pick up sqlite dep
- generated changes
Yes it will - we're actually fine to remove |
20196ac
to
529a5db
Compare
@soltysh updated and matches your suggested commit splitting |
allow mapping into a single namespace this supports quay.io which doesn't allow nested paths for images and doesn't allow creating orgs via push make the number of path components configuration for catalog mirror defaults to 2, which is what quay.io requires
529a5db
to
fe48ca0
Compare
Yes - please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/cherry-pick release-4.4 |
@ecordell: #384 failed to apply on top of branch "release-4.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This simplifies and improves the mirroring support in
oc adm catalog mirror
.DEST
as a quay.io org, and the image will be renamed for quay (1 path component for org, the rest converted to a repo name).Example:
will generate mappings like
quay.io/coreos/prometheus-operator@sha256:3daa69a8c6c2f1d35dcf1fe48a7cd8b230e55f5229a1ded438f687debade5bcf
->quay.io/my-org/coreos-prometheus-operator:1ebe036a