Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1826533: pkg/cli/admin/upgrade: Warn when --allow-upgrade-with-warnings let you through #389

Merged

Commits on May 5, 2020

  1. pkg/cli/admin/upgrade: Warn when --allow-upgrade-with-warnings let yo…

    …u through
    
    To raise awareness that users are initiating or re-targeting an update
    despite their cluster being unhealthy, which may help (updating to a
    fixed release) or hurt (re-targeting a 4.1 -> 4.2 update to start
    installing 4.3 components, which will not play nicely with any
    remaining 4.1 components).  This is bit ugly due to the two
    checkForUpgrade callsites, although I haven't tried to DRY that up.
    And I've done some minimal shuffling so checkForUpgrade returns error
    messages that are lowercased [1] and which can still be used in both
    warning strings and fatal messages.
    
    [1]: https://github.com/golang/go/wiki/CodeReviewComments#error-strings
    wking committed May 5, 2020
    Configuration menu
    Copy the full SHA
    b26467a View commit details
    Browse the repository at this point in the history