Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oc adm release extract - add option to extract credential requests only #467

Merged
merged 1 commit into from Jun 25, 2020
Merged

oc adm release extract - add option to extract credential requests only #467

merged 1 commit into from Jun 25, 2020

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Jun 16, 2020 •
edited

The purpose of this feature is to enable the manual creation of credentials required by a particular Openshift release.

https://issues.redhat.com/browse/CO-972

@csrwng
Copy link
Contributor Author

csrwng commented Jun 16, 2020

/cc @dgoodwin @joelddiaz

@csrwng csrwng force-pushed the extract_credential_requests branch from c11e6a4 to fd9b13c Compare June 16, 2020 22:43
dgoodwin
dgoodwin reviewed Jun 17, 2020
View reviewed changes
Copy link

@dgoodwin dgoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks great to me, good catch on filtering out even within multi-document yaml files too.

I feel like an option to direct to stdout instead of files might be useful, wdyt?

pkg/cli/admin/release/extract.go Outdated
@@ -64,6 +79,10 @@ func NewExtract(f kcmdutil.Factory, parentName string, streams genericclioptions
signed by the key. For more advanced signing use the generated sha256sum.txt and an
external tool like gpg.

The --credentials-requests flag filters extracted manifests to only cloud credential
requests. The --cloud flag further filters credential requests to a specific cloud.
Valid values for --cloud include aws, gcp, azure, vsphere, openstack, ovirt, and vsphere.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vsphere listed twice.

joelddiaz
joelddiaz reviewed Jun 17, 2020
View reviewed changes
Copy link

@joelddiaz joelddiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. It will simplify the documentation where we describe how to bring your own creds.

@csrwng
Copy link
Contributor Author

csrwng commented Jun 17, 2020

I feel like an option to direct to stdout instead of files might be useful, wdyt?

@dgoodwin Actually thinking some about this a bit... maybe the default should be to output to stdout. Unlike a full extract, there's really not much of a benefit in having the original file names created. Especially if we're filtering stuff out of those files.

@dgoodwin
Copy link

Personally stdout is what I would be looking for as well.

@csrwng csrwng force-pushed the extract_credential_requests branch from fd9b13c to 9a67db3 Compare June 17, 2020 14:29
@csrwng
Copy link
Contributor Author

csrwng commented Jun 17, 2020

Changed to output to stdout, fixed description

@csrwng
Copy link
Contributor Author

csrwng commented Jun 22, 2020

/test e2e-cmd

soltysh
soltysh approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 51011e4 into openshift:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgoodwin dgoodwin dgoodwin left review comments

@joelddiaz joelddiaz joelddiaz left review comments

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@csrwng @dgoodwin @openshift-ci-robot @openshift-bot @soltysh @joelddiaz @openshift-merge-robot