Bump to k8s 1.19-rc.1 #491

damemi · 2020-07-10T16:17:35Z

(This is in progress, most of these repos don't have the rc tag created yet)

damemi · 2020-07-23T15:38:01Z

go.mod

+  github.com/openshift/api => github.com/openshift/api prebase-1.19-rc.1
+  github.com/openshift/client-go => github.com/openshift/client-go prebase-1.19-rc.1
+  github.com/openshift/library-go => github.com/openshift/library-go prebase-1.19-rc.1
+  github.com/openshift/apiserver-library-go => github.com/damemi/apiserver-library-go prebase-1.19-rc.1


I couldn't find a merged rc.1 branch (only one for rc.2: openshift/apiserver-library-go#31), so note that I forked it and re-did the rc2 bump with an rc1 bump. There was only 1 other commit so for a prebase I think this is ok

damemi · 2020-07-23T15:50:33Z

@soltysh this is squashed to a point I'm comfortable with, if it passes CI it's ready to merge

damemi · 2020-07-23T17:24:12Z

/retest

damemi · 2020-07-23T17:46:47Z

I'm thinking the unit test failures are infra flakes? Seeing a bunch of them in recent runs that look like registry/image problems:

projectstatus_test.go:548: a/b test DeploymentConfig: did not have "sinatra-app-example-b deploys":
            In project example on server https://example.com:8443
            
            svc/sinatra-app-example - 172.30.17.49:8080
            
            bc/sinatra-app-example source builds git://github.com/mfojtik/sinatra-app-example on docker.io/centos/ruby-25-centos7:latest
              -> istag/sinatra-app-example:latest
              build #1 running for about a minute - 7a4f354: Prepare v1 Template types (Roy Programmer <someguy@outhere.com>) (can't push to image)
            
            Errors:
              * bc/sinatra-app-example is pushing to istag/sinatra-app-example:latest, but the administrator has not configured the integrated container image registry.
                try: oc adm registry -h
            
            View details with 'oc describe <resource>/<name>' or list resources with 'oc get all'.

=== RUN   TestNewAppRunAll/emptyDir_volumes
    --- FAIL: TestNewAppRunAll/emptyDir_volumes (0.28s)
        newapp_test.go:908: emptyDir volumes: Error mismatch! Expected <nil>, got unable to locate any images in the container image registry with name "mysql"

=== RUN   TestNewAppNewBuildEnvVars/explicit_environment_variables_for_buildConfig_and_deploymentConfig
    --- FAIL: TestNewAppNewBuildEnvVars/explicit_environment_variables_for_buildConfig_and_deploymentConfig (0.90s)
        newapp_test.go:1854: explicit environment variables for buildConfig and deploymentConfig: Error mismatch! Expected <nil>, got [unable to locate any images in the container image registry with name "centos/ruby-25-centos7", unable to locate any images in the container image registry with name "openshift/nodejs-010-centos7"]

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_oc/491/pull-ci-openshift-oc-master-unit/1286353146217500672

damemi · 2020-07-23T17:55:55Z

/retest

damemi · 2020-07-23T20:47:02Z

/retest

damemi · 2020-07-23T22:03:41Z

/retest

soltysh · 2020-07-24T11:54:52Z

/retest

soltysh · 2020-07-24T13:47:26Z

pkg/cli/login/loginoptions.go

@@ -395,6 +395,7 @@ func (o *LoginOptions) SaveConfig() (bool, error) {
 		return false, err
 	}

+	kclientcmd.UseModifyConfigLock = false


Move this to https://github.com/openshift/oc/blob/master/pkg/cli/shim_kubectl.go#L17 which is invoked for oc only in https://github.com/openshift/oc/blob/master/pkg/cli/cli.go#L347

Also it's just one place, which works for all commands.

soltysh · 2020-07-24T13:49:18Z

You missed one "k8s.io/klog" in https://github.com/openshift/oc/blob/master/pkg/cli/observe/metric.go#L12

soltysh · 2020-07-24T13:49:48Z

Split please the react commit and updated completions.

openshift-bot · 2020-08-01T21:21:37Z

/retest