Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IR-112: Pruner should be aware of OCI image configs #617

Merged
merged 2 commits into from Nov 11, 2020
Merged

IR-112: Pruner should be aware of OCI image configs #617

merged 2 commits into from Nov 11, 2020

Conversation

dmage
Copy link
Member

@dmage dmage commented Oct 21, 2020

This PR adds support of OCI images to the pruner. The pruner should

  1. keep blobs that are used by OCI images (even if they are no longer used by other schema 1 or schema 2 images)
  2. delete config/layers of OCI images if they are no longer used by any image

@dmage
Copy link
Member Author

dmage commented Oct 21, 2020

/hold

This PR should be approved by QE, Docs, Px after it's approved by the engineering team. Do not unhold it until it gets all approvals.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2020
@dmage
Copy link
Member Author

dmage commented Oct 21, 2020

/assign @ricardomaraschini

ricardomaraschini
ricardomaraschini approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@ricardomaraschini ricardomaraschini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ricardomaraschini
Copy link
Contributor

/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2020
@dmage
Copy link
Member Author

dmage commented Oct 22, 2020

/assign @soltysh

soltysh
soltysh approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2020
@soltysh
Copy link
Member

soltysh commented Oct 22, 2020

/retest

1 similar comment
@ricardomaraschini
Copy link
Contributor

/retest

@dmage
Copy link
Member Author

dmage commented Oct 23, 2020

Keeping on hold, this PR cannot be properly tested without openshift/openshift-apiserver#145.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2020
@dmage
Copy link
Member Author

dmage commented Oct 30, 2020

Passing this PR to QE, Docs, and Px.

/assign @wzheng1 @bmcelvee @sferich888

@bmcelvee
Copy link

/label docs-approved

@openshift-ci-robot
Copy link

@bmcelvee: The label(s) docs-approved cannot be applied, because the repository doesn't have them

In response to this:

/label docs-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Member

soltysh commented Nov 2, 2020

/retest

@sferich888
Copy link
Contributor

sferich888 commented Nov 2, 2020 •
edited

PX hadn't approved https://issues.redhat.com/browse/IR-115 (epic story is connected to) as of yet, however given that work is ongoing with this, we will be approving it (now), in the future, before working stories, make sure all the stories connected to the epic have all 3 acks for (px, qe, docs).

/label px-approved
/unassign @sferich888

@openshift-ci-robot
Copy link

@sferich888: The label(s) px-approved cannot be applied, because the repository doesn't have them

In response to this:

PX hadn't approved https://issues.redhat.com/browse/IR-115 (epic story is connected to) as of yet, however given that work is ongoing with this, we will be approving it (now), in the future, before working stories, make sure all the stories connected to the epic have all 3 acks for (px, qe, docs).

/label px-approved
/unassigned @sferich888

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sferich888 sferich888 removed their assignment Nov 2, 2020
ricardomaraschini
ricardomaraschini approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@ricardomaraschini ricardomaraschini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, ricardomaraschini, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dmage
Copy link
Member Author

dmage commented Nov 3, 2020

/retest

1 similar comment
@dmage
Copy link
Member Author

dmage commented Nov 9, 2020

/retest

@wzheng1
Copy link

wzheng1 commented Nov 11, 2020

/label qe-approved
QE compiled a "oc" with this pr and drafted test case for review and finished testing.

@openshift-ci-robot
Copy link

@wzheng1: The label(s) qe-approved cannot be applied, because the repository doesn't have them

In response to this:

/label qe-approved
QE compiled a "oc" with this pr and drafted test case for review and finished testing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dmage
Copy link
Member Author

dmage commented Nov 11, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 11, 2020 •
edited

@dmage: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-cmd eccfe68 link /test e2e-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@dmage dmage changed the title IR-112: Pruner should keep OCI image configs IR-112: Pruner should be aware of OCI image configs Nov 11, 2020
@openshift-merge-robot openshift-merge-robot merged commit 1bd1f5f into openshift:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@ricardomaraschini ricardomaraschini ricardomaraschini approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@soltysh soltysh

@ricardomaraschini ricardomaraschini

@wzheng1 wzheng1

@bmcelvee bmcelvee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@dmage @ricardomaraschini @soltysh @bmcelvee @openshift-ci-robot @sferich888 @wzheng1 @openshift-bot @openshift-merge-robot