Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1734504: Parts of oc adm must-gather do not respect --config CLI option #64

Merged
merged 1 commit into from Aug 22, 2019

Conversation

sanchezl
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 19, 2019
@sanchezl sanchezl force-pushed the BZ1734504 branch 2 times, most recently from 132413c to 71ce619 Compare August 19, 2019 21:32
@sanchezl sanchezl changed the title Bug 1734504 - Parts of oc adm must-gather do not respect --config CLI option Bug 1734504: Parts of oc adm must-gather do not respect --config CLI option Aug 20, 2019
@openshift-ci-robot
Copy link

@sanchezl: This pull request references Bugzilla bug 1734504, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1734504: Parts of oc adm must-gather do not respect --config CLI option

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 20, 2019
@sanchezl
Copy link
Contributor Author

/retest

@mfojtik
Copy link
Member

mfojtik commented Aug 20, 2019

/lgtm
/hold

@soltysh can you have second look?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2019
@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 20, 2019
@deads2k
Copy link
Contributor

deads2k commented Aug 20, 2019

no more commands should honor --config. The standard arg is --kubeconfig

@deads2k
Copy link
Contributor

deads2k commented Aug 20, 2019

oh, I see, this is in our already existing mistake. :(

Alright, it should honor --config.

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, sanchezl, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Member

soltysh commented Aug 22, 2019

no more commands should honor --config. The standard arg is --kubeconfig

yeah, it's not about --config per se, but rather passing flags properly down the invocation tree.

@openshift-merge-robot openshift-merge-robot merged commit b9649d0 into openshift:master Aug 22, 2019
@openshift-ci-robot
Copy link

@sanchezl: All pull requests linked via external trackers have merged. Bugzilla bug 1734504 has been moved to the MODIFIED state.

In response to this:

Bug 1734504: Parts of oc adm must-gather do not respect --config CLI option

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants