Bug 1878972: pkg/cli/admin/release: Use '-', not '=', for untranslated arches #680
Conversation
Fixing a bug from e575833 (adm release mirror: add architecture information, 2020-11-20, openshift#646), where untranslated architectures would fail with [1]: error: unable to push manifest to local-registry.apps.pravind.redhat.com:5000/ocp4/openshift4:4.7.0-0.nightly-ppc64le-2020-12-21-131639=ppc64le-prometheus: invalid tag format because tags are usually restricted to [2]: [\w][\w.-]{0,127} And \w is '[0-9A-Za-z_]' [3]. That means '=' is not a valid character. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1878972#c14 [2]: https://github.com/containers/image/blob/a5061e5a5f00333ea3a92e7103effd11c6e2f51d/docker/reference/regexp.go#L36-L37 [3]: https://github.com/google/re2/wiki/Syntax
openshift-ci-robot
added
the
approved
|
/LGTM |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pravin-dsilva, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
changed the title
|
@wking: This pull request references Bugzilla bug 1878972, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-medium
|
@wking: All pull requests linked via external trackers have merged: Bugzilla bug 1878972 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixing a bug from e575833 (#646), where untranslated architectures would fail with:
because tags are usually restricted to
[\w][\w.-]{0,127}, and\wis[0-9A-Za-z_]. That means=is not a valid character.