Bug 1890677: oc image: Include error msg when image not found and register oci schema for mediatypes #697

sallyom · 2021-01-12T15:08:45Z

oc was burying image not accessed error messages with "image does not exist" message
(Bug 1890677)

This PR gives more information about why an image was not found - and clarifies error to be image not found rather than image does not exist

Also, added the ocischema package to register OCI media types w/ oc (the error from the bug report will no longer be an error)

openshift-ci-robot · 2021-01-12T15:08:49Z

@sallyom: This pull request references Bugzilla bug 1908565, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-12T15:08:50Z

@sallyom: This pull request references Bugzilla bug 1908565, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-12T15:10:10Z

@sallyom: This pull request references Bugzilla bug 1890677, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-12T15:13:02Z

@sallyom: This pull request references Bugzilla bug 1890677, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sjenning · 2021-01-12T17:04:16Z

/lgtm

sallyom · 2021-01-12T17:25:47Z

NOTE: oc should handle manifests of type application/vnd.oci.image.manifest.v1+json
I'll open an issue/bz for that - This PR is only to stop burying that (or any other) error when an image is not found.

openshift-ci-robot · 2021-01-12T17:36:22Z

@sallyom: This pull request references Bugzilla bug 1890677, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-12T17:36:25Z

@sallyom: This pull request references Bugzilla bug 1890677, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-12T17:37:25Z

@sallyom: This pull request references Bugzilla bug 1890677, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-12T17:37:28Z

@sallyom: This pull request references Bugzilla bug 1890677, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-12T17:38:00Z

@sallyom: This pull request references Bugzilla bug 1890677, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-12T17:38:50Z

@sallyom: This pull request references Bugzilla bug 1890677, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-12T17:38:52Z

@sallyom: This pull request references Bugzilla bug 1890677, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-12T17:39:14Z

@sallyom: This pull request references Bugzilla bug 1890677, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-12T17:39:16Z

@sallyom: This pull request references Bugzilla bug 1890677, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-12T17:39:45Z

@sallyom: This pull request references Bugzilla bug 1890677, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-12T17:40:32Z

@sallyom: This pull request references Bugzilla bug 1890677, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sallyom · 2021-01-12T21:18:20Z

/retest

wking · 2021-01-13T19:15:56Z

pkg/cli/image/info/info.go

@@ -400,7 +400,7 @@ func (o *ImageRetriever) Run() error {
 						return callbackFn(name, nil, imagemanifest.NewImageForbidden(msg, err))
 					}
 					if imagemanifest.IsImageNotFound(err) {
-						msg := fmt.Sprintf("image %q does not exist", from)
+						msg := fmt.Sprintf("image %q not found: %s", from, err.Error())
 						return callbackFn(name, nil, imagemanifest.NewImageNotFound(msg, err))


Is it worth updating NewImageNotFound to suffix non-nil errors? It just serializes as the msg today, but updating it would mean we'd get the err-level detail in all of our call-sites, not just this one. Although it's only one other call-site which has a chance at a non-nil error:

$ git --no-pager grep '\.NewImageNotFound(' pkg/cli/image/extract/extract.go: return imagemanifest.NewImageNotFound(msg, err) pkg/cli/image/info/info.go: return callbackFn(name, nil, imagemanifest.NewImageNotFound(msg, err)) pkg/cli/image/info/info.go: return imagemanifest.NewImageNotFound(fmt.Sprintf("no manifests could be found for %q", from), nil)

yup I did notice there are others, I'll update

sallyom · 2021-01-13T20:16:58Z

@sjenning @wking I added the package to register the oci.image.manifest mediaType, I'll put a hold here until I push that commit, might as well fix that w/ this PR :)

/hold

openshift-ci-robot · 2021-01-13T20:47:57Z

@sallyom: This pull request references Bugzilla bug 1890677, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sallyom · 2021-01-13T20:48:17Z

/hold cancel

openshift-ci-robot · 2021-01-13T22:01:24Z

@sallyom: This pull request references Bugzilla bug 1890677, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh

/lgtm
/approve
/retest

openshift-ci-robot · 2021-01-14T17:15:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sallyom, sjenning, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-01-14T17:59:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-14T19:16:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-14T20:34:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-14T21:13:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-14T21:52:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-14T22:18:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-14T22:57:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-14T23:36:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-15T01:20:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-01-15T03:23:21Z

@sallyom: All pull requests linked via external trackers have merged:

openshift/oc#697

Bugzilla bug 1890677 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot assigned soltysh Jan 12, 2021

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 12, 2021

openshift-ci-robot requested review from mfojtik and soltysh January 12, 2021 15:09

sallyom changed the title ~~Bug 1908565: oc image info: Include error message when image not found~~ Bug 1890677: oc image info: Include error message when image not found Jan 12, 2021

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 12, 2021

openshift-ci-robot assigned sjenning Jan 12, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2021

wking reviewed Jan 13, 2021

View reviewed changes

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2021

oc image: Include error message when image not found and add oci schema

1fccd48

sallyom force-pushed the bz1908565-oci-manifest branch from b42652c to 1fccd48 Compare January 13, 2021 20:43

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2021

sallyom changed the title ~~Bug 1890677: oc image info: Include error message when image not found~~ Bug 1890677: oc image: Include error msg when image not found and register oci schema for mediatypes Jan 13, 2021

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2021

soltysh approved these changes Jan 14, 2021

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2021

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2021

openshift-merge-robot merged commit b9a6339 into openshift:master Jan 15, 2021

Bug 1890677: oc image: Include error msg when image not found and register oci schema for mediatypes #697

Bug 1890677: oc image: Include error msg when image not found and register oci schema for mediatypes #697

Conversation

sallyom commented Jan 12, 2021 • edited

openshift-ci-robot commented Jan 12, 2021

openshift-ci-robot commented Jan 12, 2021

openshift-ci-robot commented Jan 12, 2021

openshift-ci-robot commented Jan 12, 2021

sjenning commented Jan 12, 2021

sallyom commented Jan 12, 2021

openshift-ci-robot commented Jan 12, 2021

openshift-ci-robot commented Jan 12, 2021

openshift-ci-robot commented Jan 12, 2021

openshift-ci-robot commented Jan 12, 2021

openshift-ci-robot commented Jan 12, 2021

openshift-ci-robot commented Jan 12, 2021

openshift-ci-robot commented Jan 12, 2021

openshift-ci-robot commented Jan 12, 2021

openshift-ci-robot commented Jan 12, 2021

openshift-ci-robot commented Jan 12, 2021

openshift-ci-robot commented Jan 12, 2021

sallyom commented Jan 12, 2021

wking Jan 13, 2021

Choose a reason for hiding this comment

sallyom Jan 13, 2021

Choose a reason for hiding this comment

sallyom commented Jan 13, 2021 • edited

openshift-ci-robot commented Jan 13, 2021

sallyom commented Jan 13, 2021 • edited

openshift-ci-robot commented Jan 13, 2021

soltysh left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Jan 14, 2021

openshift-bot commented Jan 14, 2021

openshift-bot commented Jan 14, 2021

openshift-bot commented Jan 14, 2021

openshift-bot commented Jan 14, 2021

openshift-bot commented Jan 14, 2021

openshift-bot commented Jan 14, 2021

openshift-bot commented Jan 14, 2021

openshift-bot commented Jan 14, 2021

openshift-bot commented Jan 15, 2021

openshift-ci-robot commented Jan 15, 2021

sallyom commented Jan 12, 2021 •

edited

sallyom commented Jan 13, 2021 •

edited

sallyom commented Jan 13, 2021 •

edited