Bug 1995291: Remove docker adjective whenever possible. #767

rhatdan · 2021-03-17T10:51:40Z

No description provided.

openshift-ci-robot · 2021-03-17T10:51:59Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rhatdan
To complete the pull request process, please assign mfojtik after the PR has been reviewed.
You can assign the PR to them by writing /assign @mfojtik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-06-15T13:50:36Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2021-07-17T11:36:04Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2021-08-16T14:23:48Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2021-08-16T14:29:17Z

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhatdan · 2021-08-16T14:31:13Z

/reopen

openshift-ci · 2021-08-16T14:31:35Z

@rhatdan: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhatdan · 2021-08-16T14:32:02Z

@adambkaplan @bparees PTAL
Is anyone working on this?

rhatdan · 2021-08-16T17:35:58Z

/retest

pkg/cli/newapp/newapp.go

bparees · 2021-08-16T17:58:51Z

the build bin failed after 1m42s with reason DockerBuildFailed: Dockerfile build strategy has failed.

pkg/cli/newapp/newapp.go:273:31: undefined: newapp.AliasFlags
pkg/cli/newapp/newapp.go:1223:20: undefined: pflag
pkg/cli/newapp/newapp.go:1228:9: undefined: pflag
make: *** [vendor/github.com/openshift/build-machinery-go/make/targets/golang/build.mk:16: build] Error 2
error: build error: error building at STEP "RUN /bin/bash ...ined-variables": error while running runtime: exit status 2

bparees · 2021-08-16T17:59:56Z

seems to be missing an import

bparees · 2021-08-16T21:26:58Z

@rhatdan fix the import and i think we can merge this

rhatdan · 2021-08-17T10:49:58Z

/retest
@bparees Is there still something wrong with the import, not really sure what you mean by this?

bparees · 2021-08-17T13:16:37Z

the pflag import was missing, you appear to have fixed it. should be good to go now.

soltysh

One nit to switch from aliasing to deprecating the flag and this is good to go. If you want to land it for 4.9 you'll need to open a BZ tracking this one.

pkg/cli/newapp/newapp.go

pkg/cli/newbuild/newbuild.go

No need to container container images "Docker images". Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

openshift-ci · 2021-08-18T18:31:16Z

@bparees: This pull request references Bugzilla bug 1995291, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2021-08-18T18:31:49Z

/bugzilla refresh

openshift-ci · 2021-08-18T18:31:55Z

@bparees: This pull request references Bugzilla bug 1995291, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2021-08-18T18:33:37Z

@soltysh can you throw an approval on this?

soltysh

/approve

soltysh · 2021-08-19T12:37:38Z

The main problem with test-cmd is [sig-arch] events should not repeat pathologically but @deejross is already working on that.
/override ci/prow/e2e-agnostic-cmd

/retest

openshift-ci · 2021-08-19T12:42:16Z

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-agnostic-cmd

In response to this:

The main problem with test-cmd is [sig-arch] events should not repeat pathologically but @deejross is already working on that.
/override ci/prow/e2e-agnostic-cmd

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh · 2021-08-19T13:32:50Z

/approve

openshift-ci · 2021-08-19T13:33:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, rhatdan, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bparees · 2021-08-19T17:30:22Z

/override ci/prow/e2e-agnostic-cmd

openshift-ci · 2021-08-19T17:30:25Z

@bparees: Overrode contexts on behalf of bparees: ci/prow/e2e-agnostic-cmd

In response to this:

/override ci/prow/e2e-agnostic-cmd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2021-08-19T17:31:40Z

/override ci/prow/e2e-aws-upgrade

failure there is also unrelated ([sig-network-edge] Cluster frontend ingress remain available)

openshift-ci · 2021-08-19T17:31:43Z

@bparees: Overrode contexts on behalf of bparees: ci/prow/e2e-aws-upgrade

In response to this:

/override ci/prow/e2e-aws-upgrade

failure there is also unrelated ([sig-network-edge] Cluster frontend ingress remain available)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2021-08-20T04:11:28Z

/override ci/prow/e2e-aws-builds

openshift-ci · 2021-08-20T04:11:30Z

@bparees: Overrode contexts on behalf of bparees: ci/prow/e2e-aws-builds

In response to this:

/override ci/prow/e2e-aws-builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2021-08-20T16:35:58Z

/override ci/prow/e2e-agnostic-cmd

openshift-ci · 2021-08-20T16:36:03Z

@bparees: Overrode contexts on behalf of bparees: ci/prow/e2e-agnostic-cmd

In response to this:

/override ci/prow/e2e-agnostic-cmd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2021-08-20T16:36:07Z

/retest-required

rhatdan · 2021-08-21T10:06:53Z

/retest

openshift-bot · 2021-08-22T11:42:45Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-22T11:54:45Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-08-22T13:06:42Z

@rhatdan: All pull requests linked via external trackers have merged:

openshift/oc#767

Bugzilla bug 1995291 has been moved to the MODIFIED state.

In response to this:

Bug 1995291: Remove docker adjective whenever possible.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from adambkaplan and bparees March 17, 2021 10:51

rhatdan force-pushed the docker branch from d18f6e0 to 16d3e76 Compare March 17, 2021 10:53

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 15, 2021

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 17, 2021

openshift-ci bot closed this Aug 16, 2021

openshift-ci bot reopened this Aug 16, 2021

bparees reviewed Aug 16, 2021

View reviewed changes

pkg/cli/newapp/newapp.go Show resolved Hide resolved

bparees removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 16, 2021

rhatdan force-pushed the docker branch 3 times, most recently from dd0a355 to 4e1e01e Compare August 16, 2021 19:56

soltysh reviewed Aug 17, 2021

View reviewed changes

pkg/cli/newapp/newapp.go Show resolved Hide resolved

pkg/cli/newbuild/newbuild.go Show resolved Hide resolved

Removing the Docker adjective

7eebbe6

No need to container container images "Docker images". Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

rhatdan force-pushed the docker branch from 4e1e01e to c00cacd Compare August 17, 2021 16:29

openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Aug 18, 2021

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 18, 2021

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 18, 2021

openshift-ci bot requested a review from zhouying7780 August 18, 2021 18:31

soltysh approved these changes Aug 19, 2021

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2021

openshift-merge-robot merged commit d0cb7cc into openshift:master Aug 22, 2021

mjlshen mentioned this pull request Sep 25, 2022

Add missing RBAC for sre-build-test to get serviceaccounts openshift/managed-cluster-config#1283

Merged

Bug 1995291: Remove docker adjective whenever possible. #767

Bug 1995291: Remove docker adjective whenever possible. #767

Conversation

rhatdan commented Mar 17, 2021

openshift-ci-robot commented Mar 17, 2021

openshift-bot commented Jun 15, 2021

openshift-bot commented Jul 17, 2021

openshift-bot commented Aug 16, 2021

openshift-ci bot commented Aug 16, 2021

rhatdan commented Aug 16, 2021

openshift-ci bot commented Aug 16, 2021

rhatdan commented Aug 16, 2021

rhatdan commented Aug 16, 2021

bparees commented Aug 16, 2021

bparees commented Aug 16, 2021

bparees commented Aug 16, 2021

rhatdan commented Aug 17, 2021

bparees commented Aug 17, 2021

soltysh left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Aug 18, 2021

bparees commented Aug 18, 2021

openshift-ci bot commented Aug 18, 2021

bparees commented Aug 18, 2021

soltysh left a comment

Choose a reason for hiding this comment

soltysh commented Aug 19, 2021

openshift-ci bot commented Aug 19, 2021

soltysh commented Aug 19, 2021

openshift-ci bot commented Aug 19, 2021

bparees commented Aug 19, 2021

openshift-ci bot commented Aug 19, 2021

bparees commented Aug 19, 2021

openshift-ci bot commented Aug 19, 2021

bparees commented Aug 20, 2021

openshift-ci bot commented Aug 20, 2021

bparees commented Aug 20, 2021

openshift-ci bot commented Aug 20, 2021

bparees commented Aug 20, 2021

rhatdan commented Aug 21, 2021

openshift-bot commented Aug 22, 2021

openshift-bot commented Aug 22, 2021

openshift-ci bot commented Aug 22, 2021