Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1951203: Allow users to set a limit on ICSP file size #818

Merged
merged 1 commit into from Jun 11, 2021

Commits on Jun 11, 2021

  1. Allow users to specify max ICSP size

    Problem: It is possible for the `oc adm catalog mirror` command
    to generate ICSPs that are greater than 262144 bytes in size.
    ICSPs that exceed 262144 bytes are likely to fail when applied
    to the cluster if the objec already existed in an early state as
    the `kubectl.kubernetes.io/last-applied-configuration` annotation
    will likely exceed the 262144 annotation byte limit.
    
    Solution: Introduce a the max-icsp-size flag to the
    `oc adm catalog mirror` command, allowing users to specify the
    maximum byte size of ICSP files generated by the command. If
    an ICSP would exceed this limit, create and begin writting mirrors
    to a new ICSP.
    
    The default ICSP limit is 250000 bytes.
    awgreene committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    aa2615e View commit details
    Browse the repository at this point in the history