Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1973643: make oc logs work with BuildConfig's JenkinsPipeline strategy #863

Merged
merged 1 commit into from Jun 19, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/cli/logs/logs.go
Expand Up @@ -97,6 +97,14 @@ func NewCmdLogs(f kcmdutil.Factory, streams genericclioptions.IOStreams) *cobra.
// resource a user requested to view its logs and creates the appropriate logOptions
// object for it.
func (o *LogsOptions) Complete(f kcmdutil.Factory, cmd *cobra.Command, args []string) error {
config, err := f.ToRESTConfig()
if err != nil {
return err
}
o.Client, err = buildv1client.NewForConfig(config)
if err != nil {
return err
}
return o.LogsOptions.Complete(f, cmd, args)
}

Expand Down