-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional env vars to login #271
Comments
+1 to the overall goal here. Extra ENVs are totally useful, and welcome. This is tricky. I feel very strongly that ocm-container should be usable without installing any other tools on the host, so we'll either need to code up ocm lookups via token into the golang stuff (which I'm not opposed to - some of that exists here, but is not used at all yet: https://github.com/clcollins/ocm-container/blob/golang/pkg/ocm/ocm.go ), or move it into the internal container and process it via bash, which we do a little of, but is really messy and makes startup take longer. A lot of the ocm stuff is cribbing from osdctl, which is unfortunate. We really should try to get @AlexVulaj's ocm-common package stuff off the ground, if we can. There's too much code duplication here. Finally, we also want to consider startup time - whatever we do here, we need to be really cognizant about how many calls we make to external services and external latency. One of the big complaints I hear from folks who choose not to adopt ocm-container is the startup time, and they're not wrong. We should look at the minimum calls we need to make for any given cluster, both internal and external, make sure all required calls to get started are as concurrent as possible, and any subsequent data we need is called as needed (automatically, of course, so at least it feels like what you're going for here). |
|
When logging into a cluster I'd like some additional environment variables to be available to me, based on what type of cluster it is, and some for both:
ALL:
production
,staging
,integration
global
(this one is for future-proofing, so we can leave this off until we need it)Classic:
uhc-$OCM_ENV-$CLUSTER_ID
hive-stage-01
, etcHypershift:
The text was updated successfully, but these errors were encountered: