-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds browserless login #2
Adds browserless login #2
Conversation
Got some one thing that may help us until srelogin is in a final form: |
I tried to "merge upstream" the srelogin, and found all we need to so is set one of 4 env vars to make it work without modifications see closed PR mbarnes/work-environment#3 (comment) |
7f28b07
to
b7c805f
Compare
Nice, thanks for the tip @georgettica. I've updated the cluster-login script to what's current as of 10 minutes ago and updated ocm-container.sh to reflect the USER env var (I still want to give flexibility for those who's OCM username might be different from their kerberos username.) |
which is mine aswell, you can always do
and call the srelogin with that argument |
Right. If it changed a lot, or on a per-call basis you could do that. But setting it as a config var inside your env.source once is kind of a set-it-and-forget-it-until-you-have-to-set-this-up-again-and-then-you're-confused-because-nothing's-working-the-way-it-used-to approach. |
hahha, oki I am fine with that |
@drewandersonnz should we do something else before merging? maybe a knowledge sharing on the internal setup of the configs? |
fb5ec26
to
f9dce80
Compare
f9dce80
to
20707ca
Compare
-e "SSH_AUTH_SOCK=/tmp/ssh.sock" \ | ||
-e "KRB5CCNAME=/tmp/krb5cc" \ | ||
-e "OFFLINE_ACCESS_TOKEN" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These need to be set here so that this can become scriptable, as ~.bashrc is not run when the container inits without a TTY.
… needs to find it later to update it.
/lgtm |
Adds browserless login and the ability to automatically log into a cluster on container launch.