Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noobaa-db-0 pod not coming up with custom labels. #553

Closed
cloudbehl opened this issue Jun 9, 2020 · 3 comments · Fixed by #557
Closed

noobaa-db-0 pod not coming up with custom labels. #553

cloudbehl opened this issue Jun 9, 2020 · 3 comments · Fixed by #557

Comments

@cloudbehl
Copy link
Contributor

cloudbehl commented Jun 9, 2020

I tried the custom label thing. The CSI pods are respecting the labels but NooBaa remains in a pending state.

I am getting this error in noobaa pod.

TypeStatusUpdatedReasonMessage
PodScheduledFalse
Jun 9, 11:57 am
Unschedulable0/9 nodes are available: 9 node(s) didn't match node selector.

StorageCluster.yaml

apiVersion: v1
items:
- apiVersion: ocs.openshift.io/v1
  kind: StorageCluster
  metadata:
   name: ocs-independent-storagecluster
    namespace: openshift-storage
  spec:
    externalStorage:
      enable: true
    labelSelector:
      matchExpressions:
      - key: node-role.kubernetes.io/worker
        operator: Exists
    version: 4.5.0

Configmap - rook-ceph-operator-config.yaml

kind: ConfigMap
apiVersion: v1
metadata:
  name: rook-ceph-operator-config
  namespace: openshift-storage
  selfLink: /api/v1/namespaces/openshift-storage/configmaps/rook-ceph-operator-config
  uid: 4d771397-7670-4ed7-801f-32ae23c71df7
  resourceVersion: '560809'
  creationTimestamp: '2020-06-09T06:20:07Z'
data:
  CSI_PLUGIN_TOLERATIONS: |-

    - key: node.ocs.openshift.io/storage
      operator: Equal
      value: "true"
      effect: NoSchedule
  CSI_PROVISIONER_NODE_AFFINITY: node-role.kubernetes.io/worker
  CSI_PROVISIONER_TOLERATIONS: |-

    - key: node.ocs.openshift.io/storage
      operator: Equal
      value: "true"
      effect: NoSchedule
@cloudbehl cloudbehl changed the title NooBaa pod not coming up with custom labels. noobaa-db-0 pod not coming up with custom labels. Jun 9, 2020
@obnoxxx
Copy link
Contributor

obnoxxx commented Jun 9, 2020

Hmm, I think we need a section for placement of noobaa-db like the one for noobaa-core here: https://github.com/openshift/ocs-operator/blob/master/pkg/controller/defaults/placements.go#L208

I had expected all daemons without special treatment to pick up the "all" placement https://github.com/openshift/ocs-operator/blob/master/pkg/controller/defaults/placements.go#L15 , but that doesn't seem to happen. Maybe we need to make getPlacement fall back to "all" ? Or create specific entry for noobaa-db.

@anubhav-here-zz
Copy link
Contributor

@cloudbehl I think this works fine after the latest PR for labelSelector got merged. Correct me if i am wrong, I think this was happening due to ExternalCluster.

@cloudbehl
Copy link
Contributor Author

@anubhav-here yes I think this issue is fixed. Can you put your PR link & close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants