Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph: raise mon_max_pg_per_osd from 300 to 600 #1047

Merged
merged 1 commit into from Feb 10, 2021

Conversation

obnoxxx
Copy link
Contributor

@obnoxxx obnoxxx commented Feb 9, 2021

Allow for creating more pools.
In e529256, we raised
the mon_max_pg_per_osd to 300 to prevent pool creations
from failing. It turns out that this wasn't quite enough.
Raising it to 600 now to allow for a few more rbd pools
to be created.

Signed-off-by: Michael Adam obnox@redhat.com

@obnoxxx
Copy link
Contributor Author

obnoxxx commented Feb 9, 2021

Allow for creating more pools.
In e529256, we raised
the mon_max_pg_per_osd to 300 to prevent pool creations
from failing. It turns out that this wasn't quite enough.
Raising it to 600 now after extensive discussions to
allow for a few more rbd pools to be created.
Here is some explanation of the backgrounds:

When pools are created with target_size_ratio, they will
possibly be created with more pools initially, so that the
PG count per OSD roughly matches target size ratio percentage
of the mon_target_pg_per_osd which defaults to 100.
So the default pools that ocs-operator creates with a
target_size ratio of .49 will get 128 PGs, resulting in
some 43 PGs per OSD (replica 3). If additional pools are
created later, if they are also created with a target_size_ratio,
they might get more than the 32 default PGs as well.

The pg auto scaler can scale the pgs of the pools down
later to get closer to its target_pg_per_osd count.
But for a certain period of time, we need more headroom
to be able to create additional rbd pools.
Raising to 600 to be on the safer side.

Signed-off-by: Michael Adam <obnox@redhat.com>
@obnoxxx obnoxxx changed the title ceph: raise mon_max_pg_per_osd from 300 to 400 ceph: raise mon_max_pg_per_osd from 300 to 600 Feb 9, 2021
Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 9, 2021
@jarrpa
Copy link
Member

jarrpa commented Feb 9, 2021

/cherrypick release-4.7

@openshift-cherrypick-robot

@jarrpa: once the present PR merges, I will cherry-pick it on top of release-4.7 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jarrpa
Copy link
Member

jarrpa commented Feb 9, 2021

/cherrypick release-4.6

@openshift-cherrypick-robot

@jarrpa: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jarrpa
Copy link
Member

jarrpa commented Feb 9, 2021

/cherrypick release-4.7

@openshift-cherrypick-robot

@jarrpa: once the present PR merges, I will cherry-pick it on top of release-4.7 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@obnoxxx
Copy link
Contributor Author

obnoxxx commented Feb 9, 2021

/test ocs-operator-bundle-e2e-aws

@agarwal-mudit
Copy link
Member

/retest

@obnoxxx
Copy link
Contributor Author

obnoxxx commented Feb 10, 2021

Timeout in setting up the test env. Does not seem to be related to the patch.

/test ocs-operator-bundle-e2e-aws

@obnoxxx
Copy link
Contributor Author

obnoxxx commented Feb 10, 2021

/test ocs-operator-bundle-e2e-aws

@obnoxxx
Copy link
Contributor Author

obnoxxx commented Feb 10, 2021

/override ci/prow/red-hat-storage-ocs-ci-e2e-aws

@openshift-ci-robot
Copy link

@obnoxxx: Overrode contexts on behalf of obnoxxx: ci/prow/red-hat-storage-ocs-ci-e2e-aws

In response to this:

/override ci/prow/red-hat-storage-ocs-ci-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@obnoxxx
Copy link
Contributor Author

obnoxxx commented Feb 10, 2021

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@jarrpa
Copy link
Member

jarrpa commented Feb 10, 2021

/test ocs-operator-bundle-e2e-aws

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@jarrpa
Copy link
Member

jarrpa commented Feb 10, 2021

/override ci/prow/ocs-operator-bundle-e2e-aws

@openshift-ci-robot
Copy link

@jarrpa: Overrode contexts on behalf of jarrpa: ci/prow/ocs-operator-bundle-e2e-aws

In response to this:

/override ci/prow/ocs-operator-bundle-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jarrpa
Copy link
Member

jarrpa commented Feb 10, 2021

/cherrypick release-4.6

@openshift-cherrypick-robot

@jarrpa: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jarrpa
Copy link
Member

jarrpa commented Feb 10, 2021

/cherrypick release-4.7

@openshift-cherrypick-robot

@jarrpa: once the present PR merges, I will cherry-pick it on top of release-4.7 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@jarrpa: new pull request created: #1051

In response to this:

/cherrypick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@jarrpa: new pull request created: #1052

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2021

@obnoxxx: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/ocs-operator-ci a5db977 link /test ocs-operator-ci
ci/prow/ocs-operator-bundle-e2e-aws a5db977 link /test ocs-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants