Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

must-gather: add logs in debug file that were skipped #1111

Merged
merged 1 commit into from Apr 15, 2021
Merged

must-gather: add logs in debug file that were skipped #1111

merged 1 commit into from Apr 15, 2021

Conversation

rajatsing
Copy link

@rajatsing rajatsing commented Mar 10, 2021 •
edited

added echo messages in the gather debug log file.

Signed-off-by: RAJAT SINGH rajasing@redhat.com

@rajatsing rajatsing requested a review from crombus March 10, 2021 11:52
@rajatsing rajatsing self-assigned this Mar 10, 2021
@rajatsing rajatsing force-pushed the MG-adding-log-msg-in-gatherdebug branch from d738aff to dcc18d9 Compare March 10, 2021 11:56
@rajatsing rajatsing changed the title must-gather: added echo logs in gather debug log file must-gather: modified print to add logs in gather debug log file Mar 10, 2021
@rajatsing rajatsing changed the title must-gather: modified print to add logs in gather debug log file must-gather: modified print command to add logs in gather debug log file Mar 10, 2021
crombus
crombus suggested changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@crombus crombus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is bug which I feel we can find in other scripts as well. Look if there are another lines which we are not adding gather-debug.log. Fix all the lines in this PR.

jarrpa
jarrpa approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 22, 2021
@jarrpa jarrpa removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Mar 22, 2021
@jarrpa
Copy link
Member

jarrpa commented Mar 22, 2021

Oops, didn't notice Pulkit's review. Ignore me!

@rajatsing rajatsing force-pushed the MG-adding-log-msg-in-gatherdebug branch from dcc18d9 to 2835b08 Compare March 24, 2021 09:07
@rajatsing rajatsing requested a review from crombus March 24, 2021 09:07
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2021
crombus
crombus approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@crombus crombus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgmt

crombus
crombus suggested changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@crombus crombus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rajat use imperative commit msg.

@crombus crombus removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2021
@rajatsing rajatsing requested a review from crombus April 6, 2021 10:38
@rajatsing rajatsing force-pushed the MG-adding-log-msg-in-gatherdebug branch 2 times, most recently from de1cd53 to 1269a21 Compare April 7, 2021 08:27
@rajatsing
Copy link
Author

ok, so CI is failing which is a bit strange!. Nothing's breaking from the code's perspective.

@rajatsing
Copy link
Author

I have re-triggered the CI.

@rajatsing
Copy link
Author

Finally it passed!.

@umangachapagain
Copy link
Contributor

@crombus Can we merge this now?

@crombus
Copy link
Contributor

crombus commented Apr 12, 2021

@crombus Can we merge this now?

no, the commit msg doesn’t have must-gather tag and still not imperative commit msg.

@rajatsing rajatsing changed the title must-gather: modified print command to add logs in gather debug log file must-gather: add logs in debug file that were skipped Apr 14, 2021
must-gather: add logs in debug file that were skipped
d377007 
Signed-off-by: RAJAT SINGH <rajasing@redhat.com>
@rajatsing rajatsing force-pushed the MG-adding-log-msg-in-gatherdebug branch from 1269a21 to d377007 Compare April 14, 2021 08:36
@rajatsing
Copy link
Author

@umangachapagain @crombus please go ahead and merge!.

crombus
crombus approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@crombus crombus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crombus, jarrpa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crombus
Copy link
Contributor

crombus commented Apr 15, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 051a180 into red-hat-storage:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrpa jarrpa jarrpa approved these changes

@crombus crombus crombus approved these changes

@obnoxxx obnoxxx Awaiting requested review from obnoxxx

Assignees

@jarrpa jarrpa

@rajatsing rajatsing

@crombus crombus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rajatsing @jarrpa @umangachapagain @crombus @openshift-ci-robot @openshift-merge-robot