New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Noobaa KMS configuration only when the cluster-wide encryption is enabled #1133
Enable Noobaa KMS configuration only when the cluster-wide encryption is enabled #1133
Conversation
… is enabled Noobaa's root secret key, used for MCG encryption, should only be stored in to KMS server only if cluster wide encryption with StorageClass encryption enabled. Corrected the test cases accordingly. Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
Hi @aruniiird. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jarrpa , please take a look.. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jarrpa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-4.7 |
@agarwal-mudit: new pull request created: #1138 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Noobaa's root secret key, used for MCG encryption, should only be
stored in to KMS server only if cluster wide encryption with StorageClass
encryption enabled.
Corrected the test cases accordingly.
Signed-off-by: Arun Kumar Mohan amohan@redhat.com