fix ClusterObjectStoreState Alert empty spec #1174
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
Having no understanding of the problem you're trying to solve, I don't see the connection between the commit title and the actual changes. Can you provide a bit more description in the commit message about why/how your change addresses the problem? |
anmolsachan
changed the title
@jarrpa Thank you for the review. I have updated the commit and description. |
anmolsachan
changed the title
|
@umangachapagain Please review. |
|
You're still not really explaining how your code solves the problem. As far as I can tell, you are still returning the same thing you were returning before, I don't see why it would be any different. |
This commit fixes ClusterObjectStoreState alert spec being empty due to
which the rule was not being listed in the Prometheus Rules and alert
was not working. The reason alert spec is empty is because the function
getPrometheusRuleSpecFrom is returning empty object as the rule file
decoding is creating an object that matches the type struct
monitoringv1.PrometheusRule{} which does not match with the type of the
variable ruleSpec which is monitoringv1.PrometheusRuleSpec{}.
Signed-off-by: Anmol Sachan <anmol13694@gmail.com>
|
/test ocs-operator-ci |
|
/test ocs-operator-ci |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jarrpa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/cherry-pick release-4.8 |
|
@agarwal-mudit: new pull request created: #1196 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.7 |
|
@agarwal-mudit: new pull request created: #1233 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit fixes ClusterObjectStoreState alert spec being empty due to
which the rule was not being listed in the Prometheus Rules and alert
was not working. The reason alert spec is empty is because the function
getPrometheusRuleSpecFrom is returning empty object as the rule file
decoding is creating an object that matches the type struct
monitoringv1.PrometheusRule{} which does not match with the type of the
variable ruleSpec which is monitoringv1.PrometheusRuleS
Signed-off-by: Anmol Sachan anmol13694@gmail.com
Fix: https://bugzilla.redhat.com/show_bug.cgi?id=1948378