Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new platform GCP and AZURE #492

Merged
merged 2 commits into from May 8, 2020

Conversation

crombus
Copy link
Contributor

@crombus crombus commented Apr 30, 2020

Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but please split the GCP and Azure (not all caps) changes into two separate commits.

@crombus crombus force-pushed the rgw branch 7 times, most recently from 65a83a4 to 190d683 Compare May 6, 2020 07:14
Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with simply having a single check for all cloud platforms. Having each as its own separate if statement is preferable, especially since we're planning to allow RGW in external CephClusters.

@openshift-ci-robot
Copy link

@crombus: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws d83ca2f link /test red-hat-storage-ocs-ci-e2e-aws
ci/prow/ocs-operator-e2e-aws d83ca2f link /test ocs-operator-e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just one tiny nit. This will get caught by anyone else doing a gofmt on the file, so we want to avoid this unrelated change getting into someone else's commit.

pkg/controller/storagecluster/initialization_reconciler.go Outdated Show resolved Hide resolved
Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crombus, jarrpa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2020
@openshift-merge-robot openshift-merge-robot merged commit 5fe6e39 into red-hat-storage:master May 8, 2020
@crombus
Copy link
Contributor Author

crombus commented Jun 24, 2020

/cherrypick release-4.4

@openshift-cherrypick-robot

@crombus: new pull request created: #582

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants