Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1834327: Add ROOK_CSI_ALLOW_UNSUPPORTED_VERSION to rook operator env #512

Closed
wants to merge 1 commit into from

Conversation

Madhu-1
Copy link
Member

@Madhu-1 Madhu-1 commented May 15, 2020

The ceph-CSI version of both upstream and downstream are different
ex: the upstream versions are 2.0.0,2.1.0 etc but downstream
built version are release-4.3,release4.4 etc.
we cannot verify the supported downstream version with upstream
version.so setting ROOK_CSI_ALLOW_UNSUPPORTED_VERSION to "true"
in rook operator ENV to skip the version check for the
CSI pods.

Signed-off-by: Madhu Rajanna madhupr007@gmail.com
(cherry picked from commit c798484)

The ceph-CSI version of both upstream and downstream are different
ex: the upstream versions are 2.0.0,2.1.0 etc but downstream
built version are release-4.3,release4.4 etc.
we cannot verify the supported downstream version with upstream
version.so setting ROOK_CSI_ALLOW_UNSUPPORTED_VERSION to "true"
in rook operator ENV to skip the version check for the
CSI pods.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit c798484)
@openshift-ci-robot
Copy link

@Madhu-1: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Add ROOK_CSI_ALLOW_UNSUPPORTED_VERSION to rook operator env

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Madhu-1 Madhu-1 changed the title Add ROOK_CSI_ALLOW_UNSUPPORTED_VERSION to rook operator env BUG 1834327 Add ROOK_CSI_ALLOW_UNSUPPORTED_VERSION to rook operator env May 15, 2020
@openshift-ci-robot
Copy link

@Madhu-1: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

BUG 1834327 Add ROOK_CSI_ALLOW_UNSUPPORTED_VERSION to rook operator env

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Madhu-1
Copy link
Member Author

Madhu-1 commented May 15, 2020

/assign @umangachapagain

@openshift-ci-robot
Copy link

@Madhu-1: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/ocs-operator-e2e-aws 0684182 link /test ocs-operator-e2e-aws
ci/prow/red-hat-storage-ocs-ci-e2e-aws 0684182 link /test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@obnoxxx obnoxxx changed the title BUG 1834327 Add ROOK_CSI_ALLOW_UNSUPPORTED_VERSION to rook operator env Bug 1834327: Add ROOK_CSI_ALLOW_UNSUPPORTED_VERSION to rook operator env May 15, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label May 15, 2020
@openshift-ci-robot
Copy link

@Madhu-1: This pull request references Bugzilla bug 1834327, which is invalid:

  • expected the bug to target the "OCS 4.5.0" release, but it targets "---" instead
  • expected Bugzilla bug 1834327 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1834327: Add ROOK_CSI_ALLOW_UNSUPPORTED_VERSION to rook operator env

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 15, 2020
@obnoxxx obnoxxx added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 15, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhu-1, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2020
@jarrpa
Copy link
Member

jarrpa commented May 15, 2020

We don't need backport PRs for 4.5 yet, we haven't hit feature freeze.

@jarrpa jarrpa closed this May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants