Ceph(fix): Updates given to StorageClass won't work.

[rajatsing]

This PR fixes the issue, where the updates given on StorageClass were not working. Now, the cluster will delete the existing sc and create a new one when requested for updation.

Signed-off-by: RAJAT SINGH rajasing@redhat.com

This PR is dependent on #563 and will rebase it when that will get merged.
BZ id: https://bugzilla.redhat.com/show_bug.cgi?id=1846085

[umangachapagain]

• Commits are not clean.

• Also, here's what this code seems to be doing:

  if StorageClass is found
     delete StorageClass
     create Default StorageClass
  if StorageClass is not found
     create Default StorageClass
  

We don't want to delete existing StorageClass on every reconcile. We want to recreate it iff an update is required.

[rajatsing]

@umangachapagain , Thanks for the review, how can I check iff there's an update for the existing SC?. Thanks

[rajatsing]

I will resolve the PR once #563 is merged.

[jarrpa]

/lgtm
/retest

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa, rajatsingh25aug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jarrpa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@rajatsingh25aug: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/ocs-operator-e2e-aws	2c039ad	link	/test ocs-operator-e2e-aws
ci/prow/red-hat-storage-ocs-ci-e2e-aws	2c039ad	link	/test red-hat-storage-ocs-ci-e2e-aws
ci/prow/verify-latest-csv	6e22082	link	/test verify-latest-csv

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[humblec]

This need a backport PR to release-4.5 branch. @rajatsingh25aug @umangachapagain @jarrpa

[umangachapagain]

ci/prow/verify-latest-csv is failing and ci/prow/ocs-operator-e2e-aws was re-triggered. how did this get merged?

[rajatsing]

@umangachapagain ci/prow/verify-latest-csv fails sometimes and needs to be re-triggered in order to run it successfully.
Here's a screenshot of verify-latest-csv when triggered on my machine.

[umangachapagain]

@umangachapagain ci/prow/verify-latest-csv fails sometimes and needs to be re-triggered in order to run it successfully.

I'd expect that to be done.

Here's a screenshot of verify-latest-csv when triggered on my machine.

If it passed on local machine, it should pass on CI too.

My point being, we shouldn't merge without understanding why the CI failed. And, if we are sure it's a constantly reappearing issue in CI, we need to fix it.

[rajatsing]

@umangachapagain ci/prow/verify-latest-csv fails sometimes and needs to be re-triggered in order to run it successfully.

I'd expect that to be done.

Here's a screenshot of verify-latest-csv when triggered on my machine.

If it passed on local machine, it should pass on CI too.

My point being, we shouldn't merge without understanding why the CI failed. And, if we are sure it's a constantly reappearing issue in CI, we need to fix it.

Sure, Understood. Also, e2e CI (ci/prow/red-hat-storage-ocs-ci-e2e-aws and ci/prow/ocs-operator-e2e-aws )
fails all the time. And I've seen that on almost all the PRs.

[jarrpa]

/cherrypick release-4.5

[openshift-cherrypick-robot]

@jarrpa: #590 failed to apply on top of branch "release-4.5":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	hack/latest-csv-checksum.md5
Falling back to patching base and 3-way merge...
Auto-merging hack/latest-csv-checksum.md5
CONFLICT (content): Merge conflict in hack/latest-csv-checksum.md5
Patch failed at 0001 Ceph(fix): Updates on StorageClass won't work.

In response to this:

/cherrypick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.