Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

must-gather: Add more resources to must-gather #639

Merged
merged 1 commit into from Jul 20, 2020
Merged

must-gather: Add more resources to must-gather #639

merged 1 commit into from Jul 20, 2020

Conversation

crombus
Copy link
Contributor

@crombus crombus commented Jul 20, 2020

@crombus crombus requested a review from jarrpa July 20, 2020 14:55
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2020
jarrpa
jarrpa requested changes Jul 20, 2020
View reviewed changes
must-gather/collection-scripts/gather Outdated Show resolved Hide resolved
@crombus
must-gather: Add more resources to must-gather
2cedddc 
Signed-off-by: crombus <pkundra@redhat.com>
@crombus crombus requested a review from jarrpa July 20, 2020 15:11
jarrpa
jarrpa approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crombus, jarrpa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@crombus: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify-latest-csv 2cedddc link /test verify-latest-csv

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 6a02c6f into red-hat-storage:master Jul 20, 2020
@crombus
Copy link
Contributor Author

crombus commented Jul 20, 2020

/cherry-pick release-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 20, 2020
Merged
@openshift-cherrypick-robot
Copy link

@crombus: new pull request created: #640

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crombus crombus deleted the sc branch October 19, 2020 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrpa jarrpa jarrpa approved these changes

@mhrivnak mhrivnak Awaiting requested review from mhrivnak

@obnoxxx obnoxxx Awaiting requested review from obnoxxx

Assignees

@jarrpa jarrpa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@crombus @openshift-ci-robot @openshift-cherrypick-robot @jarrpa @openshift-merge-robot