Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1859516: x-int-or-string is not allowed for some fields #673

Merged
merged 3 commits into from Aug 5, 2020
Merged

Bug 1859516: x-int-or-string is not allowed for some fields #673

merged 3 commits into from Aug 5, 2020

Conversation

umangachapagain
Copy link
Contributor

Backport of #659

@umangachapagain
explicitly sets controller-gen verison to v0.2.5
583a335 
uses controller-gen v0.2.5 which supports Kubernetes 1.17 specs.
URL: https://github.com/openshift/kubernetes-sigs-controller-tools/releases/tag/v0.2.5

Signed-off-by: Umanga Chapagain <chapagainumanga@gmail.com>
@umangachapagain
update CRDs with latest schema
4461649 
runs `make update-generated` to patch CRDs with validations
for resources that require int-or-string type suppport.

Signed-off-by: Umanga Chapagain <chapagainumanga@gmail.com>
@umangachapagain
updates operator-bundle with latest CRDs
52fa781 
run `make gen-latest-csv` to update operator-bundle with latest CRD
and the csv checksum.

Signed-off-by: Umanga Chapagain <chapagainumanga@gmail.com>
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 5, 2020
@openshift-ci-robot
Copy link

@umangachapagain: This pull request references Bugzilla bug 1859516, which is invalid:

  • expected Bugzilla bug 1859516 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1859516: x-int-or-string is not allowed for some fields

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2020
@openshift-ci-robot
Copy link

@umangachapagain: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify-latest-csv 52fa781 link /test verify-latest-csv
ci/prow/red-hat-storage-ocs-ci-e2e-aws 52fa781 link /test red-hat-storage-ocs-ci-e2e-aws
ci/prow/ocs-operator-e2e-aws 52fa781 link /test ocs-operator-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jarrpa
jarrpa approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jarrpa,umangachapagain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2020
@jarrpa jarrpa added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 5, 2020
@jarrpa jarrpa merged commit 9d476cb into red-hat-storage:release-4.5 Aug 5, 2020
@openshift-ci-robot
Copy link

@umangachapagain: All pull requests linked via external trackers have merged: openshift/ocs-operator#673, openshift/ocs-operator#659. Bugzilla bug 1859516 has been moved to the POST state.

In response to this:

Bug 1859516: x-int-or-string is not allowed for some fields

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@umangachapagain umangachapagain deleted the bp-fix-structural-schema branch August 10, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrpa jarrpa jarrpa approved these changes

@davidvossel davidvossel Awaiting requested review from davidvossel

@egafford egafford Awaiting requested review from egafford

Assignees

@jarrpa jarrpa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@umangachapagain @openshift-ci-robot @jarrpa