Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1867885: [release-4.5][Backport] Lint fix index image validation #693

Merged
merged 3 commits into from Aug 17, 2020
Merged

Bug 1867885: [release-4.5][Backport] Lint fix index image validation #693

merged 3 commits into from Aug 17, 2020

Conversation

umangachapagain
Copy link
Contributor

Backport of #667

Signed-off-by: Umanga Chapagain chapagainumanga@gmail.com

@openshift-ci-robot
Copy link

@umangachapagain: This pull request references Bugzilla bug 1867885, which is invalid:

  • expected Bugzilla bug 1867885 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1867885: [release-4.5][Backport] Lint fix index image validation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 11, 2020
@umangachapagain umangachapagain added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 11, 2020
@umangachapagain umangachapagain requested review from jarrpa and agarwal-mudit and removed request for mhrivnak and obnoxxx August 13, 2020 08:39
agarwal-mudit
agarwal-mudit approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@agarwal-mudit agarwal-mudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2020
@agarwal-mudit
Copy link
Member

/approve

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2020
@umangachapagain
remove namespace from bundlemanifests
788abd0 
removing namspace from bundlemanifests as it is not
allowed by operator index validation.

Signed-off-by: Umanga Chapagain <chapagainumanga@gmail.com>
@umangachapagain
renaming provider as expected by validation
98fd419 
"Red Hat, Inc" is not allowed as a provider by operator
index validator. So, renaming it to "Red Hat" as suggested.

Signed-off-by: Umanga Chapagain <chapagainumanga@gmail.com>
@umangachapagain
updates bundle and CSV
9d7debd 
running `make gen-latest-csv` to update the bundle and CSV with
validation changes.

Signed-off-by: Umanga Chapagain <chapagainumanga@gmail.com>
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 17, 2020
agarwal-mudit
agarwal-mudit approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@agarwal-mudit agarwal-mudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2020
@openshift-ci-robot
Copy link

@umangachapagain: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify-latest-csv 9d7debd link /test verify-latest-csv
ci/prow/ocs-operator-e2e-aws 9d7debd link /test ocs-operator-e2e-aws
ci/prow/red-hat-storage-ocs-ci-e2e-aws 9d7debd link /test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jarrpa jarrpa added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: agarwal-mudit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 590641c into red-hat-storage:release-4.5 Aug 17, 2020
@openshift-ci-robot
Copy link

@umangachapagain: All pull requests linked via external trackers have merged: openshift/ocs-operator#693. Bugzilla bug 1867885 has been moved to the MODIFIED state.

In response to this:

Bug 1867885: [release-4.5][Backport] Lint fix index image validation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@umangachapagain umangachapagain deleted the bp-release-4.5-pr-667 branch August 20, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agarwal-mudit agarwal-mudit agarwal-mudit approved these changes

@jarrpa jarrpa Awaiting requested review from jarrpa

Assignees

@agarwal-mudit agarwal-mudit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@umangachapagain @openshift-ci-robot @agarwal-mudit @jarrpa @openshift-merge-robot