Enabling 'snapshotter' feature in external cluster mode

[aruniiird]

A very minor change to enable Snapshotter feature in external cluster mode.

Signed-off-by: Arun Kumar Mohan amohan@redhat.com

[openshift-ci-robot]

Hi @aruniiird. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aruniiird]

Adding a WIP PR, as the changes are yet to be tested...

CC: @Madhu-1 , @humblec

[humblec]

@aruniiird I have a dump question: Isnt it applicable for both internal and external mode ? because we are adding the resource in the reconcile function which is equally applicable for both. Am I missing anything here?

[aruniiird]

Removing the WIP tag, as the feature is working on ceph version which supports ceph fs subvolume info command.
We used the following ceph version,

ceph versions
{
    "mon": {
        "ceph version 14.2.8-111.el8cp (2e6029d57bc594eceba4751373da6505028c2650) nautilus (stable)": 3
    },
    "mgr": {
        "ceph version 14.2.8-111.el8cp (2e6029d57bc594eceba4751373da6505028c2650) nautilus (stable)": 3
    },
    "osd": {
        "ceph version 14.2.8-111.el8cp (2e6029d57bc594eceba4751373da6505028c2650) nautilus (stable)": 3
    },
    "mds": {
        "ceph version 14.2.8-111.el8cp (2e6029d57bc594eceba4751373da6505028c2650) nautilus (stable)": 3
    },
    "rgw": {
        "ceph version 14.2.8-111.el8cp (2e6029d57bc594eceba4751373da6505028c2650) nautilus (stable)": 3
    },
    "overall": {
        "ceph version 14.2.8-111.el8cp (2e6029d57bc594eceba4751373da6505028c2650) nautilus (stable)": 15
    }
}

@jarrpa , can you please take a look...

Attaching the screen shots

RBD Snapshot

CephFS Snapshot

[aruniiird]

@aruniiird I have a dumb question: Isn't it applicable for both internal and external modes? because we are adding the resource in the reconcile function which is equally applicable for both. Am I missing anything here?

@humblec , the code path taken for converged/internal mode and external mode cluster are different. You can see it here. So I have to add the ensureSnapshotClasses method to external mode as well.
You are right, the snapshotter feature should be applicable for both modes, but on the initial PR we added it only to the internal mode.

[openshift-ci-robot]

@iamniting: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

@aruniiird: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws	37fec69	link	/test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, jarrpa, raghavendra-talur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jarrpa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment