add new property TuneFastDeviceClass

[crombus]

Signed-off-by: crombus pkundra@redhat.com

[crombus]

@jarrpa I ran make gen-latest-csv but crd changes were not done. What can I do to make those changes

[openshift-ci-robot]

@iamniting: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[iamniting]

I think we should make these changes in two commits first one for the move part and second one for add part.

[crombus]

@jarrpa the ci test is failing at govet. need help there.

[kesavanvt]

@crombus since the implementation of throttleStorageDevices method is modified, it's required to make necessary changes in TestThrottleStorageDevices (throttleStorageDevices is invoked here ) under storagecluster_controller_test.go.

[jarrpa]

Test failures are valid. Please rebase and resolve. Always run make ocs-operator-ci before any push.

[crombus]

the PR is dependent on #912. rook 1.5.1. I'll rebase it.
The failures are because of govet.

[obnoxxx]

the PR is dependent on #912. rook 1.5.1. I'll rebase it.
The failures are because of govet.

#912 has merged now @crombus - you can rebase

[obnoxxx]

Not strictly required for a 4.7 feature, afaict, but would be good to have before feature freeze...

[crombus]

/test ocs-operator-ci

[obnoxxx]

/test ocs-operator-bundle-e2e-aws

[obnoxxx]

/test ocs-operator-bundle-e2e-aws

[obnoxxx]

/retest

[obnoxxx]

/test ocs-operator-ci

[obnoxxx]

To my taste, the main commit (add new property TuneFastDeviceClass) does a bit too much. I would have recommended to split the refactoring (moving of function from reconcile.go to cephcluster.go, etc) into separat commits. But not blocking because of this.

The whole terminology with Tune[Fast|Slow]DeviceClass is rather confusing or non-obvious, but I guess it is what it is.

For now the patch might be enough, but conceptually, I think we need the list of device types to tune for slow or fast types not to be just storage class names and hard code selection of provisioners in the throttle function but instead we should have the devices types be pairs of provisioner and storage class name.

Since this can be done in a follow-up cleanup PR, approving this one for now.

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kesavanvt, obnoxxx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [obnoxxx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-merge-robot]

@crombus: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws	2e8b7aa	link	/test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[crombus]

/cherry-pick release-4.6

[openshift-cherrypick-robot]

@crombus: #864 failed to apply on top of branch "release-4.6":

Applying: add new property TuneFastDeviceClass
Using index info to reconstruct a base tree...
M	pkg/apis/ocs/v1/storagecluster_types.go
M	pkg/controller/storagecluster/cephcluster.go
M	pkg/controller/storagecluster/reconcile.go
M	pkg/controller/storagecluster/storagecluster_controller_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/controller/storagecluster/storagecluster_controller_test.go
CONFLICT (content): Merge conflict in pkg/controller/storagecluster/storagecluster_controller_test.go
Auto-merging pkg/controller/storagecluster/reconcile.go
CONFLICT (content): Merge conflict in pkg/controller/storagecluster/reconcile.go
Auto-merging pkg/controller/storagecluster/cephcluster.go
Auto-merging pkg/apis/ocs/v1/storagecluster_types.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add new property TuneFastDeviceClass
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[agarwal-mudit]

@crombus https://bugzilla.redhat.com/show_bug.cgi?id=1909793 still doesn't have all the acks. Pls do not merge it into 4.6 yet.
Also, you should first backport it to 4.7

[crombus]

@agarwal-mudit this feature is already in 4.7.
And this will require manual BP of the two PR's mentioned in BZ.
I would say it is tricky to BP.

[agarwal-mudit]

@agarwal-mudit this feature is already in 4.7.
And this will require manual BP of the two PR's mentioned in BZ.
I would say it is tricky to BP.

Ok, then lets not backport it to 4.6
Probably we can GA Azure without this feature. @obnoxxx