Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csv-merger: Add OCS Toleration to metrics-exporter #870

Merged
merged 1 commit into from Oct 29, 2020
Merged

csv-merger: Add OCS Toleration to metrics-exporter #870

merged 1 commit into from Oct 29, 2020

Conversation

jarrpa
Copy link
Member

@jarrpa jarrpa commented Oct 27, 2020

Signed-off-by: Jose A. Rivera jarrpa@redhat.com

umangachapagain
umangachapagain requested changes Oct 28, 2020
View reviewed changes
tools/csv-merger/csv-merger.go Outdated Show resolved Hide resolved
tools/csv-merger/csv-merger.go Outdated Show resolved Hide resolved
@jarrpa
csv-merger: Add OCS Toleration to metrics-exporter
bb0cd29 
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2020
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 28, 2020 •
edited

@jarrpa: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws bb0cd29 link /test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jarrpa
Copy link
Member Author

jarrpa commented Oct 28, 2020

@umangachapagain Seems the change I submitted to openshift/release went through, we now need explicit /lgtm again. :)

@umangachapagain
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9424a79 into red-hat-storage:master Oct 29, 2020
@jarrpa
Copy link
Member Author

jarrpa commented Oct 29, 2020

/cherrypick release-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 29, 2020
Merged
@openshift-cherrypick-robot
Copy link

@jarrpa: new pull request created: #875

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jarrpa jarrpa deleted the add-metrics-toleration branch August 31, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umangachapagain umangachapagain umangachapagain approved these changes

@davidvossel davidvossel Awaiting requested review from davidvossel

@obnoxxx obnoxxx Awaiting requested review from obnoxxx

Assignees

@umangachapagain umangachapagain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jarrpa @openshift-merge-robot @umangachapagain @openshift-ci-robot @openshift-cherrypick-robot