Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

must-gather: some improvements in snapshot info collection #876

Merged
merged 1 commit into from Oct 30, 2020
Merged

must-gather: some improvements in snapshot info collection #876

merged 1 commit into from Oct 30, 2020

Conversation

agarwal-mudit
Copy link
Member

  1. change log file names to rbd_vol_and_snap_info &
    cephfs_subvol_and_snap_info
  2. add subvolumegroup name (csi)
  3. add snapshot count for cephFS subvolumes

Signed-off-by: Mudit Agarwal muagarwa@redhat.com

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2020
@crombus
Copy link
Contributor

crombus commented Oct 30, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2020
@crombus
Copy link
Contributor

crombus commented Oct 30, 2020

/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 30, 2020
@agarwal-mudit
must-gather: some improvements in snapshot info collection
b8fcfa4 
1. change log file names to rbd_vol_and_snap_info &
   cephfs_subvol_and_snap_info
2. add subvolumegroup name (csi)
3. add snapshot count for cephFS subvolumes

Signed-off-by: Mudit Agarwal <muagarwa@redhat.com>
@crombus
Copy link
Contributor

crombus commented Oct 30, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crombus, Madhu-1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2020
@openshift-merge-robot
Copy link
Contributor

@agarwal-mudit: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws b8fcfa4 link /test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@agarwal-mudit
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit eded544 into red-hat-storage:master Oct 30, 2020
@agarwal-mudit
Copy link
Member Author

/cherrypick release-4.6

@agarwal-mudit agarwal-mudit deleted the snap branch October 30, 2020 10:29
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 30, 2020
Merged
@openshift-cherrypick-robot
Copy link

@agarwal-mudit: new pull request created: #877

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crombus crombus crombus approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@obnoxxx obnoxxx Awaiting requested review from obnoxxx

Assignees

@crombus crombus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@agarwal-mudit @crombus @openshift-ci-robot @openshift-merge-robot @openshift-cherrypick-robot @Madhu-1