Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storagecluster: remove the deviceType from validateStorageDeviceSets #945

Merged
merged 1 commit into from Dec 10, 2020
Merged

storagecluster: remove the deviceType from validateStorageDeviceSets #945

merged 1 commit into from Dec 10, 2020

Conversation

crombus
Copy link
Contributor

@crombus crombus commented Dec 7, 2020 •
edited

Remove the metadata setting from storage cluster as it is benefiting nothing.
just check for invalid deviceType and throw error.

Signed-off-by: crombus pkundra@redhat.com

@crombus crombus requested a review from jarrpa December 7, 2020 17:09
@crombus crombus added this to the ocs 4.7 feature freeze milestone Dec 7, 2020
@crombus crombus added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 7, 2020
@crombus crombus removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 7, 2020
obnoxxx
obnoxxx requested changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this PR? Why is it needed? Please elaborate in commit message / PR description.

@crombus
storagecluster: do not set metadata for deviceType
2c9e6e1 
do not set metadata for deviceType storagecluster
just check for deviceType.

Signed-off-by: crombus <pkundra@redhat.com>
obnoxxx
obnoxxx approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, obnoxxx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2020
@obnoxxx
Copy link
Contributor

obnoxxx commented Dec 10, 2020

/override ci/prow/red-hat-storage-ocs-ci-e2e-aws

@openshift-ci-robot
Copy link

@obnoxxx: Overrode contexts on behalf of obnoxxx: ci/prow/red-hat-storage-ocs-ci-e2e-aws

In response to this:

/override ci/prow/red-hat-storage-ocs-ci-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 2b08dd6 into red-hat-storage:master Dec 10, 2020
@obnoxxx obnoxxx mentioned this pull request Dec 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obnoxxx obnoxxx obnoxxx approved these changes

@iamniting iamniting iamniting approved these changes

@jarrpa jarrpa Awaiting requested review from jarrpa

@umangachapagain umangachapagain Awaiting requested review from umangachapagain

Assignees

@obnoxxx obnoxxx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@crombus @openshift-ci-robot @obnoxxx @iamniting @openshift-merge-robot