Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be More Tolerant of Network Timeouts #1178

Closed
ALRubinger opened this issue Jan 8, 2019 · 4 comments
Closed

Be More Tolerant of Network Timeouts #1178

ALRubinger opened this issue Jan 8, 2019 · 4 comments
Labels
priority/Medium Nice to have issue. Getting it done before priority changes would be great.

Comments

@ALRubinger
Copy link

[kind/Enhancement]

Which functionality do you think we should update/improve?

So I went to use odo to connect to an OpenShift cluster on another continent. Here's what happened:

[alr@tubescreamer ~]$ odo login %URL% -u user18 -p %PASSWORD%
Login successful.

You have one project on this server: "user18"

Using project "user18".

Cool! Now let's make an app.

[alr@tubescreamer ~]$ odo app create test
 ✗  Unable to connect to OpenShift cluster, is it down?

Allright; so we've hit a connection timeout. But the problem is in the messaging; this could be improved. I suggest the following fixes to the error message:

  1. Change to say "✗ Unable to connect to OpenShift cluster, is it down? Perhaps you're hitting a network timeout?"
  2. Add some context to suggest a workaround in case the timeout is not sufficient. For instance telling the user to run odo utils config set Timeout XX where XX is a new timeout value in seconds, say, 20, should do the trick.

Additionally, how about increasing the default timeout? I believe 1 second is the default? Surely we can be more permissive, yeah?

@cdrage cdrage self-assigned this Jan 8, 2019
@cdrage
Copy link
Member

cdrage commented Jan 8, 2019

More notes / suggestions:

  • If the connection is taking more than 3 seconds / too longer to connect to OpenShift, we should use a spinner or at least indicate to the user that the connection is delayed and taking a while...
  • Ex: If > 3 seconds, Do: Spinner + INFO, Else: Continue

@jorgemoralespou
Copy link
Contributor

Additionally to this, --skip-connection-check prevented this error from happening.

@kadel kadel added priority/Medium Nice to have issue. Getting it done before priority changes would be great. state/In Analysis labels Jan 14, 2019
@cdrage cdrage added this to To do in Sprint 161 via automation Jan 16, 2019
@kadel kadel removed this from To do in Sprint 161 Feb 6, 2019
@kadel
Copy link
Member

kadel commented Dec 16, 2019

/close

@openshift-ci-robot
Copy link
Collaborator

@kadel: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
None yet
Development

No branches or pull requests

5 participants