Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging documentation #1187

Closed
cdrage opened this issue Jan 9, 2019 · 3 comments
Closed

Update logging documentation #1187

cdrage opened this issue Jan 9, 2019 · 3 comments

Comments

@cdrage
Copy link
Member

cdrage commented Jan 9, 2019

https://openshiftdo.org/logging/

The current documentation is incorrect for erroring. We do not use glog for erroring, we should provide examples that functions must provide err return as errors are handled more upstream (within cmd/ files)

@surajnarwade
Copy link
Contributor

surajnarwade commented Jan 14, 2019

@kadel
Copy link
Member

kadel commented Dec 16, 2019

done
/close

@openshift-ci-robot
Copy link
Collaborator

@kadel: Closing this issue.

In response to this:

done
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants