Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for the completion handlers that don't have them #1225

Closed
geoand opened this issue Jan 23, 2019 · 4 comments
Closed

Add unit tests for the completion handlers that don't have them #1225

geoand opened this issue Jan 23, 2019 · 4 comments
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done.

Comments

@geoand
Copy link
Contributor

geoand commented Jan 23, 2019

[kind/Enhancement]

Which functionality do you think we should update/improve?

We should include unit tests for the completion handlers that currently lack them: like the app completion handler

Why is this needed?

Since the new completion architecture allows us to write the completion handlers in go, it makes sense to test this code as we would any other piece of odo
@geoand geoand mentioned this issue Jan 23, 2019
Merged
@geoand geoand added state/Ready priority/Medium Nice to have issue. Getting it done before priority changes would be great. labels Jan 31, 2019
@girishramnani girishramnani added this to In consideration in Sprint 162 via automation Feb 4, 2019
@kadel kadel added priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done. and removed priority/Medium Nice to have issue. Getting it done before priority changes would be great. labels Feb 4, 2019
@kadel kadel moved this from For consideration to To do in Sprint 162 Feb 4, 2019
@mohammedzee1000
Copy link
Contributor

mohammedzee1000 commented Feb 7, 2019 •
edited

You are talking about completion handlers as in complete in complete-validate-run pattern , looking into it

@mohammedzee1000
Copy link
Contributor

Some of these have UI input which might make them harder to test, as UI does not seem to be mocked, writing tests for those that don't, should have something working soon

@kadel kadel added this to For consideration in Sprint 163 via automation Feb 25, 2019
@kadel kadel moved this from For consideration to To do in Sprint 163 Feb 27, 2019
@girishramnani girishramnani removed this from To do in Sprint 162 Mar 18, 2019
@girishramnani girishramnani removed this from To do in Sprint 163 Mar 18, 2019
@girishramnani girishramnani added this to For consideration in Sprint 165 via automation Mar 18, 2019
@girishramnani girishramnani added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Mar 18, 2019
@girishramnani girishramnani removed this from For consideration in Sprint 165 Apr 10, 2019
@kadel
Copy link
Member

kadel commented Dec 16, 2019

/close

@openshift-ci-robot
Copy link
Collaborator

@kadel: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l rm3l added the estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done.
Projects
odo Project
Archived in project
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kadel @rm3l @geoand @girishramnani @mohammedzee1000 @openshift-ci-robot