Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup project and milestone via prow #1663

Closed
mohammedzee1000 opened this issue Apr 29, 2019 · 49 comments
Closed

Setup project and milestone via prow #1663

mohammedzee1000 opened this issue Apr 29, 2019 · 49 comments
Labels
priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done.
Projects
testproject

Comments

@mohammedzee1000
Copy link
Contributor

mohammedzee1000 commented Apr 29, 2019 •
edited

[kind/Enhancement]

Which functionality do you think we should update/improve?

We should redirect milestone and project setup via bot commands

Why is this needed?

Makes it closer to OpenShift workflow. Also allows us to remove write aceess from most contributors preventing manual errors
@mohammedzee1000
Copy link
Contributor Author

PR for enabling plugins openshift/release#3624

@mohammedzee1000
Copy link
Contributor Author

Need to setup necessary groups / teams to give permissions to

@kadel
Copy link
Member

kadel commented Apr 29, 2019

we already have @openshift/odo-maintainers group (3185642)

@mohammedzee1000
Copy link
Contributor Author

Yes, i am mainly looking at how it can be configured

@kadel kadel added the priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). label Apr 30, 2019
@kadel kadel added this to For consideration in Sprint 166 via automation Apr 30, 2019
@girishramnani girishramnani moved this from For consideration to To do in Sprint 166 Apr 30, 2019
@mohammedzee1000
Copy link
Contributor Author

Milestone plugin enabled on odo maintainers team. project plugin is underway
openshift/release#3742

@mohammedzee1000 mohammedzee1000 moved this from To do to In progress in Sprint 166 May 10, 2019
@mohammedzee1000
Copy link
Contributor Author

@kadel if you can confirm both plugins are functional, i will close this issue

@girishramnani
Copy link
Contributor

/milestone 1.0

@openshift-ci-robot openshift-ci-robot added this to the 1.0 milestone May 16, 2019
@girishramnani
Copy link
Contributor

/project Sprint 166

@girishramnani
Copy link
Contributor

/project asdf

@girishramnani
Copy link
Contributor

/project Sprint 167 In Consideration

@mohammedzee1000
Copy link
Contributor Author

/project "Sprint 167" "In Consideration"

@mohammedzee1000
Copy link
Contributor Author

/project

@kadel
Copy link
Member

kadel commented May 16, 2019

milestone command is working perfectly, but project does not :-(

@girishramnani girishramnani added this to For consideration in Sprint 167 via automation May 22, 2019
@girishramnani girishramnani removed this from In progress in Sprint 166 May 22, 2019
@girishramnani girishramnani moved this from For consideration to In progress in Sprint 167 May 22, 2019
@kadel
Copy link
Member

kadel commented May 30, 2019

any updates on /project command? It is still not working :-(

@mohammedzee1000
Copy link
Contributor Author

/cc @openshift/openshift-team-developer-experience ^^

@adambkaplan
Copy link
Member

Issues related to prow should be sent to @openshift/openshift-team-developer-productivity-test-platform

@stevekuznetsov
Copy link

Looking at the help for it, it's not obvious how to do a project name with more than one word:

https://prow.svc.ci.openshift.org/command-help?repo=openshift%2Fodo#project

/project foo

@openshift-ci-robot
Copy link
Collaborator

@stevekuznetsov: You must be a member of the openshift/odo github team to set the project and column.

In response to this:

Looking at the help for it, it's not obvious how to do a project name with more than one word:

https://prow.svc.ci.openshift.org/command-help?repo=openshift%2Fodo#project

/project foo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Collaborator

@stevekuznetsov: You must be a member of the openshift/odo github team to set the project and column.

In response to this:

Looking at the help for it, it's not obvious how to do a project name with more than one word:

https://prow.svc.ci.openshift.org/command-help?repo=openshift%2Fodo#project

/project foo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevekuznetsov
Copy link

So the plugin does seem to be on...

@openshift-ci-robot
Copy link
Collaborator

@mohammedzee1000: You must be a member of the openshift/odo-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your odo maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

Strange this is also something strange, you are able to add, but im not. I can manipulate milestone though
/milestone 1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mohammedzee1000
Copy link
Contributor Author

Ok the team id is same but team indicated is different o_O

@mohammedzee1000
Copy link
Contributor Author

https://github.com/openshift/release/blob/master/cluster/ci/config/prow/plugins.yaml#L774-L785
How is there so much diff in behavior?

@stevekuznetsov
Copy link

Neither of those teams exist, I don't know how you configured them -- the team that does exist is odo-maintainers-1 https://github.com/orgs/openshift/teams/odo-maintainers-1

@mohammedzee1000
Copy link
Contributor Author

mohammedzee1000 commented Jun 7, 2019 •
edited

I got the ID from github api
https://developer.github.com/v3/teams/#list-teams
openshift/release#3731 (comment)
And then configured project plugin with same ID openshift/release#3742

@kadel kadel added this to For consideration in Sprint 168 via automation Jun 12, 2019
@kadel kadel removed this from In progress in Sprint 167 Jun 12, 2019
@kadel kadel moved this from For consideration to In progress in Sprint 168 Jun 12, 2019
@kadel
Copy link
Member

kadel commented Jun 12, 2019

/remove-priority high
/priority low

@openshift-ci-robot openshift-ci-robot added priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done. and removed priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). labels Jun 12, 2019
@mohammedzee1000
Copy link
Contributor Author

@stevekuznetsov

@stevekuznetsov
Copy link

Hi?

@girishramnani
Copy link
Contributor

/project "Sprint 169"

@openshift-ci-robot
Copy link
Collaborator

@girishramnani: You must be a member of the openshift/odo github team to set the project and column.

In response to this:

/project "Sprint 169"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@girishramnani girishramnani removed this from In progress in Sprint 168 Jul 3, 2019
@girishramnani girishramnani added this to For consideration in Sprint 169 via automation Jul 3, 2019
@girishramnani girishramnani moved this from For consideration to In progress in Sprint 169 Jul 3, 2019
@girishramnani girishramnani removed this from In progress in Sprint 169 Jul 24, 2019
@girishramnani girishramnani added this to For consideration in Sprint 170 via automation Jul 24, 2019
@girishramnani girishramnani moved this from For consideration to In progress in Sprint 170 Jul 24, 2019
@girishramnani
Copy link
Contributor

/project "Sprint 169"

@openshift-ci-robot
Copy link
Collaborator

@girishramnani: You must be a member of the openshift/odo github team to set the project and column.

In response to this:

/project "Sprint 169"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@girishramnani girishramnani removed this from In progress in Sprint 170 Jul 24, 2019
@girishramnani girishramnani removed this from the 1.0 milestone Jul 24, 2019
@girishramnani
Copy link
Contributor

/project "Sprint 169"

@openshift-ci-robot
Copy link
Collaborator

@girishramnani: You must be a member of the openshift/odo github team to set the project and column.

In response to this:

/project "Sprint 169"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@girishramnani
Copy link
Contributor

TBH this issue has been open for long and we have been able to live without this feature. Hence closing. If someone feels it is still relevant then they can re-open this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done.
Projects
No open projects
testproject
  
test
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kadel @adambkaplan @girishramnani @stevekuznetsov @mohammedzee1000 @openshift-ci-robot