"odo config unset" doesn't unset an environment variable but says it did

[dharmit]

[kind/bug]

What versions of software are you using?

• Operating System: all
• Output of odo version: master

How did you run odo exactly?

1. Set an env var using odo config set --env.
2. Unset it using odo config unset --env foo=bar.
3. Unset it using odo config unset --env foo (don't mention the value of foo this time).
   Verify output of odo config view at the end of each step

$ odo config set --env foo=bar
Environment variables were successfully updated.
Run `odo push --config` command to apply changes to the cluster.

$ odo config view
ENVIRONMENT VARIABLES
------------------------------------------------
NAME    VALUE
foo     bar

COMPONENT SETTINGS
------------------------------------------------
PARAMETER         CURRENT_VALUE
Type              nodejs
Application       app
Project           myproject
SourceType        local
Ref               
SourceLocation    ./
Ports             8080/TCP
Name              nodejs-nodejs-ex-ulzb
MinMemory         
MaxMemory         
Ignore            
MinCPU            
MaxCPU           

$ odo config unset --env foo=bar
Environment variables were successfully updated.

$ odo config view
ENVIRONMENT VARIABLES
------------------------------------------------
NAME    VALUE
foo     bar        <------------------- This still shows!

COMPONENT SETTINGS
------------------------------------------------
PARAMETER         CURRENT_VALUE
Type              nodejs
Application       app
Project           myproject
SourceType        local
Ref               
SourceLocation    ./
Ports             8080/TCP
Name              nodejs-nodejs-ex-ulzb
MinMemory         
MaxMemory         
Ignore            
MinCPU            
MaxCPU            

$ odo config unset --env foo
Environment variables were successfully updated.

$ odo config view
COMPONENT SETTINGS
------------------------------------------------
PARAMETER         CURRENT_VALUE
Type              nodejs
Application       app
Project           myproject
SourceType        local
Ref               
SourceLocation    ./
Ports             8080/TCP
Name              nodejs-nodejs-ex-ulzb
MinMemory         
MaxMemory         
Ignore            
MinCPU            
MaxCPU            

Actual behavior

odo says that it has successfully unset the env var but it actually hasn't.

Expected behavior

Either odo config unset should complain that it can't handle the input given by user or unset the value as user would expect

[kadel]

/kind bug
/priority high

[amitkrout]

@dharmit Is it a correct approach to unset env var, i mean passing the key value pair to unset the env var. Practically i would pass the key instead of passing the whole key value pair. But yes in some point i would say its a corner usecase.

[dharmit]

@amitkrout yes, I would not pass the key-value pair when doing unset. And it could be a corner use-case depending on how frequently/infrequently one uses env vars in their components. Assuming it's a corner case, odo should, IMHO, at least not say that it managed to unset the env var.

In my particular case, I ended up discarding and redoing demo recordings because env var was already there in the component's pod. 😂

[cdrage]

Assigning this to you @dharmit since you already have a PR open and we combined our separate PR's :)

[girishramnani]

#2274 is already merged and this is a duplicate to that